Skip to content

fix(bench): send QUIC closes before exiting - #59

Closed
fperex wants to merge 1 commit into
mainfrom
fix/bench-quic-close
Closed

fperex wants to merge 1 commit into
mainfrom
fix/bench-quic-close

Conversation

@fperex

@fperex fperex commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Problem

moq-bench returned from main without closing its client, so the runtime exited before any QUIC close was sent. Every peer then waited out its idle timeout (about 10 s) to notice the benchmark had left.

Fix

Stop the connection tasks and await Client::close before returning. The stop result is preserved through cleanup, so a stats-output failure still fails the run.

Test

rs/moq-bench/tests/shutdown.rs spawns the real CLI with 8 connections and --duration 1s against a local listener and requires every peer to see the close before a 10 s bound. On main it fails 3 of 3 (benchmark peer never received close); with the fix it passes 5 of 5. just check passes.

API and wire

None. moq-bench is unpublished; only its shutdown path changed.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Stop connection tasks and await Client::close before the runtime exits. Preserve
the stop result through cleanup so report failures still fail the run.

Prove the actual CLI sends clean closes to all eight peers before it exits.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fperex

fperex commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Closing: this fix is included in #3 on top of current main. (Written by Claude Opus 5.5)

@fperex fperex closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant