Repository navigation
Conversation
Stop connection tasks and await Client::close before the runtime exits. Preserve the stop result through cleanup so report failures still fail the run. Prove the actual CLI sends clean closes to all eight peers before it exits. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing: this fix is included in #3 on top of current main. (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
moq-benchreturned frommainwithout closing its client, so the runtime exited before any QUIC close was sent. Every peer then waited out its idle timeout (about 10 s) to notice the benchmark had left.Fix
Stop the connection tasks and await
Client::closebefore returning. The stop result is preserved through cleanup, so a stats-output failure still fails the run.Test
rs/moq-bench/tests/shutdown.rsspawns the real CLI with 8 connections and--duration 1sagainst a local listener and requires every peer to see the close before a 10 s bound. On main it fails 3 of 3 (benchmark peer never received close); with the fix it passes 5 of 5.just checkpasses.API and wire
None.
moq-benchis unpublished; only its shutdown path changed.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code