Repository navigation
Conversation
The player waited only on Ctrl-C, so a supervisor's SIGTERM killed it on the default action and the relay waited out its idle timeout to notice. Use the shared shutdown signal in the window, and close the client after playback so the QUIC close goes out, as `run_stages` does. Exercise both signals with real signals in isolated nextest processes: one against `shutdown_signal`, one against the window's shutdown event. Refs #51. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing: this fix is included in #3 on top of current main. (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The native player (
moq ... play) waited only on Ctrl-C, so a supervisor's SIGTERM killed it on the default action.run_playalso never closed the client, so even a clean exit sent no QUIC close and the relay noticed only after its idle timeout.Fix
The window waits on the shared
shutdown_signal()(SIGINT, and SIGTERM on Unix).run_playkeeps the attached connection and the client and closes both after playback, including when setup fails, asrun_stagesalready does.doc/bin/cli.mdstates the signal behavior.Test
play::window::tests::sigterm_finishes_playbacksends a real SIGTERM and requires the window's shutdown event; it is killed by the signal on main and passes with the fix. Twoshutdown_signaltests cover SIGINT and SIGTERM. These rely on nextest's per-test processes. Manual run against a local relay: after SIGTERM the relay logged a clean close 5 ms later; on main it logged an idle timeout about 10 s later.just checkpasses with and without--features play.API and wire
None.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code