Skip to content

Add in a part_svc.comment, with ability to edit/view#49

Open
Jayceh wants to merge 2 commits into
freeside:FREESIDE_4_BRANCHfrom
Jayceh:part_svc-comment
Open

Add in a part_svc.comment, with ability to edit/view#49
Jayceh wants to merge 2 commits into
freeside:FREESIDE_4_BRANCHfrom
Jayceh:part_svc-comment

Conversation

@Jayceh

@Jayceh Jayceh commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

orthogonal to the part_pkg.comment.

@Jayceh

Jayceh commented Aug 31, 2015

Copy link
Copy Markdown
Contributor Author

->insert works, but apparently there is currently an issue with ->replace, debugging now

Fix bug where interface wouldn't post the comment field across the various svc_column elements
@Jayceh

Jayceh commented Aug 31, 2015

Copy link
Copy Markdown
Contributor Author

Interface usage should now be fixed.

@freeside

freeside commented Sep 9, 2015

Copy link
Copy Markdown
Owner

You added the column, and the ability to edit it, but it doesn't do anything else. Can you please share a complete change that shows where this field would be displayed in the interface?

@Jayceh

Jayceh commented Sep 9, 2015

Copy link
Copy Markdown
Contributor Author

I didn't do that yet just waiting to see if it was worth doing based on
your feedback. If you think it fits then yes, I'll finish it and add it to
the pull request so the interface is usable.

On Tuesday, September 8, 2015, Freeside Internet Services, Inc. <
notifications@github.com> wrote:

You added the column, and the ability to edit it, but it doesn't do
anything else. Can you please share a complete change that shows where this
field would be displayed in the interface?


Reply to this email directly or view it on GitHub
#49 (comment).

Jayce^

Preparing Deseret - UtahPreppers
ΜΟΛΩΝ ΛΑΒΕ

@freeside

freeside commented Sep 9, 2015

Copy link
Copy Markdown
Owner

Sure, it seems like it fits. I'd have to know specifically where you intend to add it in the interface to provide more feedback than that. I don't think it is ready to merge until it is a complete change that displays in the interface in an appropriate way in additional to the database and edit changes.

@Jayceh

Jayceh commented Sep 9, 2015

Copy link
Copy Markdown
Contributor Author

Agreed on the merge. I posted it just to have some source material to
discuss. Will finish out the rest and submit.

On Tue, Sep 8, 2015 at 6:37 PM, Freeside Internet Services, Inc. <
notifications@github.com> wrote:

Sure, it seems like it fits. I'd have to know specifically where you
intend to add it in the interface to provide more feedback than that. I
don't think it is ready to merge until it is a complete change that
displays in the interface in an appropriate way in additional to the
database and edit changes.


Reply to this email directly or view it on GitHub
#49 (comment).

Jayce^

Preparing Deseret - UtahPreppers
ΜΟΛΩΝ ΛΑΒΕ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants