Skip to content

Fix undefined behaviour in MSG_STRING_DUP #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timando wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined behaviour in MSG_STRING_DUP #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libsofia-sip-ua/msg/sofia-sip/msg_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ SOFIAPUBFUN issize_t msg_parse_next_field(su_home_t *home, msg_header_t *prev,

/** Duplicate string. @HI */
#define MSG_STRING_DUP(p, d, s) \
(void)((s)?((p)=(char*)memccpy((void *)((d)=(char*)p),(s),0,INT_MAX))\
(void)((s)?((p)=(char*)stpcpy((void *)((d)=(char*)p),(s)) + 1)\
:((d)=NULL))

/* Solaris has broken memccpy - it considers last argument as signed */
Expand Down