feat(security): доступ к Docker через docker-socket-proxy - #59
Merged
Conversation
mail-api no longer mounts the raw, root-equivalent /var/run/docker.sock. Instead the default compose runs a least-privilege tecnativa/docker-socket-proxy and mail-api reaches the Docker API over TCP (DOCKER_HOST=tcp://docker-socket-proxy:2375). The proxy enables only what mail-api needs — CONTAINERS, EXEC, POST, ALLOW_RESTARTS — with the raw socket mounted read-only on an internal network. A mail-api compromise can no longer drive arbitrary host containers/images/volumes. - lib/docker: resolveDockerOptions(env) — DOCKER_HOST (tcp URL) → host/port, else DOCKER_SOCKET_PATH (+ unit test) - refactor all five dockerode clients (dms, engine, ops, migrator, nginx reloader) to take a `dockerOptions` connection; index.ts resolves it once - env: DOCKER_HOST (optional); compose: docker-socket-proxy service + internal docker_proxy network, mail-api no longer mounts the socket - docs: deployment.md + CLAUDE.md Backward compatible: unset DOCKER_HOST to fall back to the mounted socket. Closes #19 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что это
mail-api больше не монтирует сырой, root-эквивалентный
/var/run/docker.sock(закрывает #19). Вместо этого дефолтный compose поднимает least-privilegetecnativa/docker-socket-proxy, а mail-api ходит в Docker API по TCP (DOCKER_HOST=tcp://docker-socket-proxy:2375).Прокси разрешает только то, что реально нужно mail-api —
CONTAINERS,EXEC,POST,ALLOW_RESTARTS; сырой сокет примонтирован read-only в прокси на internal-сети. Компрометация mail-api больше не даёт управлять произвольными контейнерами/образами/томами хоста.Изменения
lib/docker:resolveDockerOptions(env)—DOCKER_HOST(tcp-URL) → host/port/protocol, иначеDOCKER_SOCKET_PATH(+ unit-тест).dockerOptions;index.tsрезолвит соединение один раз.DOCKER_HOST(опционально).docker-socket-proxy+ internal-сетьdocker_proxy; mail-api больше не монтирует сокет,depends_onпрокси._docs/deployment.md+ CLAUDE.md (таблица конфига).Обратная совместимость
Убрать
DOCKER_HOST→ падение обратно на прямой сокет (тогда mail-api снова нужен docker-groupgroup_add). Флаг-контролируемо, дефолт SQLite... то есть дефолт compose — через прокси.Проверки
typecheck·lint·format:check·vitest(528 ✓). Compose провалидирован YAML-парсером (сервисы/сети/переменные на месте, сокет у mail-api убран).Заметка
Точный набор флагов прокси и TCP-подключение проверяются на живом стеке (docker CLI в CI-песочнице недоступен).
/version(согласование API dockerode) в tecnativa-прокси разрешён по умолчанию; если понадобится — добавитьINFO=1/VERSION=1.restartтребуетALLOW_RESTARTS=1(включён).Closes #19
🤖 Generated with Claude Code