Skip to content

Add batch member confirmation system (preregistering members) - #314

Merged
georgelgeback merged 5 commits into
mainfrom
batch-member-confirm
Aug 14, 2026
Merged

Add batch member confirmation system (preregistering members)#314
georgelgeback merged 5 commits into
mainfrom
batch-member-confirm

Conversation

@georgelgeback

@georgelgeback georgelgeback commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Changes:

  • Adding batch members with multiple different identifiers
  • New tab pre-filtered on this to automatically accept members who have been pre-registered

Requires the following backend PR to be merged before tests have any chance to pass:

…ing members easier, add some missing translations, fix broken member edit form
@georgelgeback
georgelgeback requested a review from Copilot June 30, 2026 16:57

This comment was marked as outdated.

…. Better errors for fully empty or trailing fields. Fix batch add not clearing properly. Add missing translation key
@maffe03

maffe03 commented Aug 14, 2026

Copy link
Copy Markdown
Member

Från copilot (local):

Potential Areas to Review:

  • The batch input format (complex vs. simple) is inferred from semicolon presence—ensure this is intuitive for end users
  • Phone number validation uses Swedish region—confirm this is the desired behavior
  • Consider adding unit tests for handleBatchAdd validation logic
  • The STIL ID regex pattern (/^[a-z]{2}\d{4}[a-z]{2}-s$/) should be documented or explained

Recommendation
Ready for review with the understanding that backend integration is pending. All frontend type checking passes and the implementation is well-structured.

@maffe03 maffe03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgelgeback
georgelgeback merged commit 5205362 into main Aug 14, 2026
1 check passed
@georgelgeback
georgelgeback deleted the batch-member-confirm branch August 14, 2026 16:06
hannesblaman pushed a commit that referenced this pull request Aug 17, 2026
* Add new tabs for managing preregistrations of members to make confirming members easier, add some missing translations, fix broken member edit form

* Better phone number parser which doesn't fire on stil-id with numbers. Better errors for fully empty or trailing fields. Fix batch add not clearing properly. Add missing translation key

* dummy commit

* Add stil-id comment and force stil-id to be lowercase instead of failing a batch add

---------

Co-authored-by: Manfred Malmros <manfred.malmros@gmail.com>
hannesblaman added a commit that referenced this pull request Aug 22, 2026
* Create admin page for enclose moose

* Created foundations for tables and forms ~loosely~ based on songs page
(if you see any remnants of that)

* Allow admins to set unlock codes and hints for adventure missions. Update adventure mission admin page to the new AdminForm standard.

* Add preliminary batch member adding to groups (#309)

* Add preliminary batch member adding to groups

* Fix bug where password ends up in URL, add loading check for slow connections, fix some lint issues.

* Fixed member edit submit not working

* Don't throw on error to avoid crashing page

* use normalizeIdentifier, better error message, click to expand list of matched users

---------

Co-authored-by: Hannes Blåman <hannes@blaman.com>

* Complete revamp of event creation UI (including option to specify group types for nollning events) (#318)

* Began laying foundation for specifying group type ui

* Add form field for setting group types

* Began form redesign

* UI basically functional

* All day now works as expected

* Added translate to Pick a date

* Removed nollning alcohol clarification

* Start time+dots vertical layout for really small screens

* Add lottery option

* Fixed lottery not being handled properly

* Lottery badge distinguishes between fcfs and lottery

* Only show allowed group types

* Change default value to be all mentor group types

* Distribuering -> Utdelning

* Move page tips to relevant input fields

* Added "Group" suffixes

* Tried to make form elements as consistent as possible 🫩
I would like to thank my mother, my father, but most of all Claude
Sorry if I broke anything else I wanna kill this spaghetti code

* Some small refactorings

* Added badge to clarify if event is for mentor or mission group

* Fixed some things on event details/signup page

* Fixed SOME event-related english localization pet peeves

* Some more pet peeve localization fixes

* Correct datetime picker localized format

* Fix typo

* Use a hardcoded enum instead of importing an unnamed enum from the API spec. Use this to mprove  GroupTypeSelect group mapping.

* Restored StyledCreatableSelect + related QoL

* Consistent badges!

* Form messages

* Added showMissingTexts boolean

* Mentor group type validation!

* Moved out localization identification

* Restore shadcn ui changes

* Local granularity type

* This code duplication is killing me🫠

* Don't allow signing up to introduction event without group

* Fix bug related to a mismatch in displayed group and actual form value

* Add refine check for empty mentor group type select to the edit and add forms too. Add form message where missing.

---------

Co-authored-by: georgelgeback <georgelgeback@gmail.com>

* Signup priority fix  (#320)

* Send null when clearing priority instead of not sending any value

* Add support for priority holders to skip group_name checks

* Improve error handling on registration, trim whitespace from registration fields (#321)

* Add batch member confirmation system (preregistering members) (#314)

* Add new tabs for managing preregistrations of members to make confirming members easier, add some missing translations, fix broken member edit form

* Better phone number parser which doesn't fire on stil-id with numbers. Better errors for fully empty or trailing fields. Fix batch add not clearing properly. Add missing translation key

* dummy commit

* Add stil-id comment and force stil-id to be lowercase instead of failing a batch add

---------

Co-authored-by: Manfred Malmros <manfred.malmros@gmail.com>

* Localization changes

* Add functionality for managing enclose moose levels

* Localization

* Oops missed some stuff

* Add error messages to edit schema

* Fix level edit not working

* Allow admin form number clearing + fix enclose moose editing not working

* Fixed lingering level editing bugs

* Added daily/bonus level filtering

* Encoded grid guide

* Added initial sorting

* Cleanup

* No edit scores

* a -> link

* Remove dead import and fix pressing enter when editing opening the help menu

* undefined -> ""

* Un-hardcoded datetime placeholder whooOOOPS

* preventDefault no longer needed

---------

Co-authored-by: georgelgeback <georgelgeback@gmail.com>
Co-authored-by: Georg Elgebäck <50551748+georgelgeback@users.noreply.github.com>
Co-authored-by: Manfred Malmros <manfred.malmros@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants