Skip to content

Update nixpkgs - #35

Closed
arminsabouri wants to merge 1 commit into
mainfrom
update-nix-lock
Closed

arminsabouri wants to merge 1 commit into
mainfrom
update-nix-lock

Conversation

@arminsabouri

Copy link
Copy Markdown
Collaborator

flake.lock file is more than 30 days old. Causing ci to fail. Regenerated with nix flake update nixpkgs

@arminsabouri

Copy link
Copy Markdown
Collaborator Author

I didnt see dependabot already did this in #34

flake.lock file is more than 30 days old. Causing ci to fail.
Regenerated with `nix flake update nixpkgs`
@arminsabouri

Copy link
Copy Markdown
Collaborator Author

hmm #2 is still failing after being rebased so we may actually need this update

@yuval-block yuval-block left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol i was stumped by this for like a solid 15 minutes, but #34 didn't actually update nixpkgs, only other inputs

the underlying problem is determinate systems' weekly cooldown nixpkgs release is not supported:

https://github.com/dependabot/dependabot-core/blob/66c6c6be2c2c5b1aa1c85c385ab5d47c315a65b7/nix/lib/dependabot/nix/file_parser.rb#L125

since dependabot has cooldowns of its own i guess we could just use that

if you want you can just update this to regular nixpkgs. since i checked determinate now also offers 26.05, the absence of that is almost certainly why i chose the weekly cooldown of the unstable branch instead of that. the main tradeoff here:

  • 26.05 will be stabler and likely more secure but would need to be updated bi-annually, which if we forget to do we may end up on unsupported
  • unstable provides more up to date tools, but we already get up to date rust toolchain from rust-overlay so this would be more for developer tools, it's just rolling updates

stable or unstable + cool down period gives us some buffer for supply chain attacks etc, which is a good idea since devshells are one of the primary outputs, but i'm somewhat ambivalent about which, so i guess let's switch to nixpkgs-unstable + weekly cool down and then consider if we want to switch to stable as a seaprate issue

amazing how github is so consistently disappointing, almost everything they've added which initially made me happy, shortly after also made me sad... kind of boggles the mind that github doesn't support git based flake updating... sigh

@yuval-block

yuval-block commented Sep 9, 2026 •

Copy link
Copy Markdown
Collaborator

btw if you only update the flake input, then dependabot wil immediately open a PR after merging so i would suggest not updating flake.lock in this PR so that we can verify that it does the right thing

sorry that's wrong, when you set

inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";

then that will recreate the flake.lock which will be up to date anyway

@arminsabouri

Copy link
Copy Markdown
Collaborator Author

superceeded by #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants