Skip to content

Rewrite README chapter links when assembling the mdbook - #73

Merged
yuval-block merged 1 commit into
check-linksfrom
rewrite-readme-links
Oct 21, 2026
Merged

yuval-block merged 1 commit into
check-linksfrom
rewrite-readme-links

Conversation

@yuval-block

Copy link
Copy Markdown
Collaborator

The repo root README uses docs/ paths for GitHub, buta mdbook assembly places it alongside the chapters. This change ensures that the README can link to chapters in both contexts.

@yuval-block
yuval-block requested a review from bc1cindy October 21, 2026 19:51
@yuval-block
yuval-block added this pull request to stack #58 October 21, 2026 19:51
@github-actions

Copy link
Copy Markdown
range-diff for force push 38b003af76 → 08db6ba233 October 21, 2026 20:07 UTC: 1 unchanged, 2 dropped

reproduce: git range-diff b3e699e..38b003a 0265cc4..08db6ba

1:  b5c425f393 < -:  ---------- Check the links of the built site
2:  9223409868 < -:  ---------- Serve the not-found page's assets from /docs/
3:  38b003af76 = 1:  08db6ba233 Rewrite README chapter links when assembling the mdbook

The repo root README uses docs/ paths for GitHub, buta mdbook assembly
places it alongside the chapters. This change ensures that the README
can link to chapters in both contexts.
@github-actions

Copy link
Copy Markdown
range-diff for force push 08db6ba233 → 0d3df1cdf3 October 21, 2026 20:15 UTC: 1 unchanged, 1 dropped

reproduce: git range-diff 68cf907..08db6ba a39193a..0d3df1c

1:  0265cc4a17 < -:  ---------- Serve the not-found page's assets from /docs/
2:  08db6ba233 = 1:  0d3df1cdf3 Rewrite README chapter links when assembling the mdbook

@bc1cindy bc1cindy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0d3df1c

thanks!

this keeps README links working in the book

@yuval-block
yuval-block added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit 5e034ba Oct 21, 2026
3 checks passed
@yuval-block
yuval-block deleted the rewrite-readme-links branch October 21, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants