Repository navigation
Add secp256k1 KEM support - #5
Merged
Merged
Conversation
Collaborator
|
Give these commits a squash please |
0xZaddyy
force-pushed
the
add-secp256k1
branch
from
October 9, 2026 15:10
201fbdb to
229c016
Compare
arminsabouri
requested changes
Oct 9, 2026
arminsabouri
left a comment
arminsabouri
left a comment
Collaborator
There was a problem hiding this comment.
Maybe request is around the keyconfig retention logic.
0xZaddyy
force-pushed
the
add-secp256k1
branch
from
October 14, 2026 13:18
229c016 to
3b6c3a1
Compare
arminsabouri
requested changes
Oct 14, 2026
arminsabouri
left a comment
arminsabouri
left a comment
Collaborator
There was a problem hiding this comment.
There are many refrences to this odd key config issue upstream. I think we create an ONE fixme / issue and refrence it in the code. But I don't believe we need to refactor our code heavily to deal with an upstream bug. Esp one only affecting this experimental feature. Additionally we know the current secp256k1 gateways are not advesrtising aes AEAD key configs -- so don't go thru all of this effor.t
samething for the just file. Whats with all the changes?
0xZaddyy
force-pushed
the
add-secp256k1
branch
from
October 15, 2026 11:40
3b6c3a1 to
fdbddcc
Compare
arminsabouri
approved these changes
Oct 15, 2026
0xZaddyy
force-pushed
the
add-secp256k1
branch
from
October 15, 2026 14:29
fdbddcc to
ba6452b
Compare
Add an optional `secp256k1` feature that depends on bitcoin-ohttp alongside ohttp. Key configs are decoded by whichever backend supports their KEM, so a single client works with both kinds of gateway and the feature is additive. Co-authored-by: Oladapo Oyindamola <111582215+0xZaddyy@users.noreply.github.com>
0xZaddyy
force-pushed
the
add-secp256k1
branch
from
October 15, 2026 14:37
ba6452b to
0aa9a35
Compare
Collaborator
|
msrv check seems flaky. BUt not because of this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds experimental
secp256k1KEM support using thebitcoin-ohttpcrate, conditionally aliased asohttpbehind thesecp256k1feature flag.