Repository navigation
Rename known_length to known_padded_bhttp_req_length - #9
Merged
arminsabouri merged 1 commit intoOct 23, 2026
Merged
Conversation
Ayoazeez26
force-pushed
the
rename-known-length
branch
2 times, most recently
from
October 23, 2026 10:03
0f011fc to
c24c328
Compare
This was referenced Oct 23, 2026
arminsabouri
self-requested a review
October 23, 2026 12:36
Collaborator
|
@Ayoazeez26 thanks for picking up this ticket! Merged #10 so this branch needs a rebase |
"Known length" is ambiguous: it reads like the BHTTP known-length framing mode rather than the size each inner request is padded to. Name it after what it sets. This is a breaking change to OhttpClient and WasmOhttpClient, and to the field of Error::KnownLengthTooSmall. Suggested in fungi-protocol/fungi#141 (comment) Closes fungi-protocol#8
Ayoazeez26
force-pushed
the
rename-known-length
branch
from
October 23, 2026 14:02
c24c328 to
a124cad
Compare
Contributor
Author
|
@arminsabouri happy to help! Successfully rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
OhttpClient::known_lengthandWasmOhttpClient::known_lengthtoknown_padded_bhttp_req_length, along with the corresponding field ofError::KnownLengthTooSmall."Known length" reads like the BHTTP known-length framing mode rather than the size each inner request is padded to.
Breaking change: callers of
.known_length(..)(e.g. fungi-protocol/fungi#141) need updating.Suggested in fungi-protocol/fungi#141 (comment)
Closes #8
The failing
msrvjob is tracked in #7.