Repository navigation
Fix Ethereum milestones in active liquidity filter - #101
Merged
Merged
Conversation
✅ Deploy Preview for futarchy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR #100 hardcoded
getSubgraphEndpoint(100), so Ethereum pool IDs were sent to the Gnosis index and returned no rows. The fail-closed liquidity gate then hid the Ethereum EIP-8363 milestone despite approximately $213.9k of live reserves.Validation
node --test auto-qa/tests/active-market-liquidity.test.mjs— 6/6 passnpm run auto-qa:test— 695/695 passnpm run build-only— pass (existing unrelated warnings remain)$213,930.22liquidity