Repository navigation
Conversation
andydotxyz
requested changes
Sep 14, 2026
andydotxyz
left a comment
andydotxyz
left a comment
Contributor
There was a problem hiding this comment.
Great update thanks, but very wordy in the comments / doc - can you trim?
| func NewExitCallback(app fyne.App, win fyne.Window) | ||
| ``` | ||
|
|
||
| ## Localization |
Contributor
There was a problem hiding this comment.
This is a huge amount of text for a small addition. One of the nice things about using standard language package should be that it doesn't need a lot of setup etc. Can this be trimmed to the essentials?
| }() | ||
| } | ||
| d = dialog.NewConfirm("Application Update", info+"\n\nDo you wish to update?\n", func(ok bool) { | ||
| // info comes from the selfupdate package (e.g. "New version found) and is looked |
Contributor
There was a problem hiding this comment.
The note about where info comes from is helpful - but adding info about how lang.L works is superfluous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Fyne's standard localization package (lang) to fyneselfupdate. All strings shown in the update/restart confirmation dialogs and the download progress dialog are now passed through lang.L(...), so they will be translated if the consuming application provides a matching translation bundle and simply fall back to English otherwise.
No breaking changes to the public API. Behavior is unchanged for applications that don't call lang.AddTranslations* dialogs still show the same English text as before (used as the fallback).