Skip to content

duplicate-bodies red on master: train_slice_model copies file_io_contract's byte_sum #10203

Closed as not planned

Description

@gHashTag

Boundary

  • specs/ml/file_io_contract.t27: byte_sum becomes pub
  • specs/ml/train_slice_model.t27: its private copy byte_total is deleted and the two call sites use byte_sum

User Scenarios

Requirements

  • No behaviour change: the two bodies are identical, so the checksum of every image stays the same.
  • No ledger bless: the copy is removed, not recorded.

Success Criteria

  • python3 tools/dupe_scan.py exits 0 ("no new duplicate body").
  • t27c check and t27c test-report pass for both specs, and for specs/ml/host_io_model.t27, which also imports file_io_contract.
  • The duplicate-bodies check is green on the PR.

Requirements

FR-001: The byte_sum function in specs/ml/file_io_contract.t27 MUST be made public so that importing specs can call it directly.
FR-002: The private byte_total function in specs/ml/train_slice_model.t27 MUST be deleted and its two call sites MUST be updated to use ml::file_io_contract::byte_sum instead.
FR-003: The checksum behavior for every image MUST remain identical to before the change (no behavioral change).
FR-004: The duplicate function body MUST be removed from the codebase rather than recorded in any ledger or allow-list.

Activity

  1. added
    shape-refusedClosed by the issue-shape gate (specs/policy/issue_shape.t27); a passing edit reopens it
    on Oct 18, 2026
  2. github-actions commented on Oct 18, 2026

    @github-actions
    Contributor

    Closed by the issue-shape gate (specs/policy/issue_shape.t27, #7498): an issue must have the template's sections. Edit the body; an edit that passes reopens it.

    • missing: ## Requirements -- numbered obligations, FR-001: ... MUST ...
  3. added a commit that references this issue on Oct 18, 2026
    12ef567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    queen-shapedshape-refusedClosed by the issue-shape gate (specs/policy/issue_shape.t27); a passing edit reopens it

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions