You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
dupe-ledger: bless log_frame copied by particle_engine (#10310) after #10312 #10315
duplicate-bodies is red on master at 4414941: a body written under log_frame is now copied [2] time(s) and was in no ledger. #10310 added specs/t27f/particle_engine.t27, whose log_frame has the same body as the one in specs/t27f/particle_field.t27. #10312 blessed the ledger before #10310 merged, so this copy is in no ledger. Every PR based on master now fails the check (for example #10314).
Boundary
tools/duplicate_bodies_baseline.txt: the one line log_frame 2, written by python3 tools/dupe_scan.py --bless.
Not in scope:
merging the two log_frame bodies into one shared helper (the spec owners' call);
any other ratchet.
Scenarios
Given master with this ledger, When python3 tools/dupe_scan.py runs, Then it exits 0.
Given a spec that copies another known body, When the scan runs, Then it still fails.
Requirements
FR-001: The ledger MUST be the tool's --bless output, not hand-edited.
FR-002: The change MUST add exactly one group and change no existing count.
Success Criteria
duplicate-bodies is green on master and on PRs based on it.
Close criteria
The PR merges, and master's duplicate-bodies check passes.
Activity
dupe-ledger: bless log_frame copied by particle_engine (Closes #10315) (