You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
spec(maxpool2d_layer): a lowerable out_side(kernel, stride) for the nn-maxpool widget #10664
gHashTag/trinity#1696 (course 10, neural networks) was refused for one defect (review 5565039954): the widget nn-maxpool hand-holds K_OUT_SIDES = [2, 2, 3, 1]. Those are out_size(4, cfg(k, s)) from specs/ml/layers/maxpool2d_layer.t27, but out_size takes a MaxPool2DConfig struct and does not lower to WASM, so logic.js lists it in __NOT_LOWERED__ and the widget has no compiled way to get the output side.
the widget's four configs (K_KERNELS = [2, 3, 2, 4], K_STRIDES = [2, 1, 1, 1] on trinity's feat/course-neural-networks): (2,2)->2, (3,1)->2, (2,1)->3, (4,1)->1;
edges: a 1 x 1 window keeps the side (1,1)->4; a stride that does not divide rounds down, (3,2)->1 and (1,3)->2.
Done when t27c test-report is all PASS with 0 vacuous, a mutant of the fn goes red, the seal is saved, and t27-logic.mjs lists outSide among the lowered fns.
Not here: re-vendoring into trinity, calling outSide(k, st) in tool.js and dropping K_OUT_SIDES (a later step on trinity#1696).
Boundary
specs/ml/layers/maxpool2d_layer.t27
.trinity/seals/Maxpool2d.json, .trinity/seals/layers_Maxpool2d.json (its seal files)
Closed by the issue-shape gate (specs/policy/issue_shape.t27, #7498): an issue must have the template's sections. Edit the body; an edit that passes reopens it.
missing: ## User Scenarios -- at least one Given/When/Then scenario
missing: ## Requirements -- numbered obligations, FR-001: ... MUST ...
missing: ## Success Criteria -- an outcome a machine can settle: a number with a unit, a backticked file, exit 0, or a backticked command
Activity
github-actions commentedon Oct 18, 2026
Closed by the issue-shape gate (specs/policy/issue_shape.t27, #7498): an issue must have the template's sections. Edit the body; an edit that passes reopens it.
FR-001: ... MUST ...exit 0, or a backticked commandspec(maxpool2d_layer): a lowerable out_side(kernel, stride) for the n…