You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
duplicate-bodies red on master since #7490: the LinkSection port copies the linker constructors on purpose #7867
duplicate-bodies has been red on master since a6d4e55 (#7490, run), on master and on every PR after it:
a body written under LinkSection_text is now copied [2] time(s) and was in no ledger
(same for LinkSection_data, LinkSection_bss)
specs/port/bootstrap/src/compiler/LinkSection_text.t27 ports LinkSection::text/data/bss from bootstrap/src/compiler.rs. To clear the types ratchet (#7437), #7490 aligned its record with the owner spec specs/fpga/linker.t27 (alignment became align, []const u8 became &str). That made the three constructors byte-identical to link_text/link_data/link_bss.
The copy is deliberate. The port mirrors compiler.rs one-to-one, port specs import no other module, and the linker's functions are private. So the fix is to record the three groups, not to reuse them: python3 tools/dupe_scan.py --bless.
FR-001: The three constructor groups (LinkSection_text, LinkSection_data, LinkSection_bss) in the port spec MUST be recorded in the duplicate-bodies ledger as intentional copies.
FR-002: The fix MUST NOT change the port spec's one-to-one mirroring of bootstrap/src/compiler.rs.
FR-003: The fix MUST NOT introduce reuse of the private linker functions from specs/fpga/linker.t27.
Success Criteria
Running python3 tools/dupe_scan.py --bless exits 0 and records the three groups.
Subsequent run of python3 tools/dupe_scan.py (without --bless) exits 0 with zero unrecorded duplicates for LinkSection_text, LinkSection_data, LinkSection_bss.
Activity
fix(dupe): port #7868 -- record the LinkSection port copy (Refs #7867)
gHashTag commentedon Oct 8, 2026
The fix is #7864: the same
dupe_scan --blessofLinkSection_text,_dataand_bss. #7868 is closed as its duplicate.Generated by Claude Code