You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
types classification: the Pair row is stale after #8550 #8560
#8550 removed Pair from docs/reports/type_conflicts.json, but #8535 had also classified it in docs/reports/type_conflicts_classified.json and in the tables of docs/TYPE_CONFLICTS.md. Master's Corpus Ratchet now fails "type_conflicts_classified.json disagrees with the tree": STALE Pair: classified, but no longer conflicting -- drop the row.
Acceptance criteria
tri types classified prints OK on master.
The Pair object and its table row are removed, and the DISTINCT counts drop from 37 to 36. Nothing else changes.
Given the type_conflicts_classified.json and TYPE_CONFLICTS.md still contain a Pair entry, when running tri types classified, then the command fails with "STALE Pair: classified, but no longer conflicting".
Given the Pair row has been removed from both type_conflicts_classified.json and TYPE_CONFLICTS.md, when running tri types classified, then the command prints OK and exits 0.
Given the Pair row is removed, when checking the DISTINCT count in TYPE_CONFLICTS.md, then the count drops from 37 to 36 with no other changes.
Requirements
FR-001: The Pair object MUST be removed from docs/reports/type_conflicts_classified.json.
FR-002: The Pair table row MUST be removed from docs/TYPE_CONFLICTS.md.
FR-003: The DISTINCT count in docs/TYPE_CONFLICTS.md MUST change from 37 to 36.
FR-004: Running tri types classified MUST exit 0 and print OK.
Activity
types classification: drop the stale Pair row (Closes #8560) (#8561)