You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
master: Spec Guards red -- optimizer.t27 phantom duplicate test names minted from comment prose #8580
master: Spec Guards red -- optimizer.t27 phantom duplicate test names minted from comment prose
Does any spec declare one name twice fails on master (3d1a4fe) with:
NEW: specs/compiler/optimizer.t27 declares 2 name(s) twice and is not in the baseline
warning: `test implementation` is declared 2 times -- every backend rejects a redeclaration
warning: `test documents` is declared 2 times -- every backend rejects a redeclaration
The two "duplicates" are not declarations. #8502's census tests carry inline ; comments whose PROSE contains the word test followed by an identifier:
var result = true ; Placeholder for actual test implementation (twice)
then result == true ; This test documents the requirement - ... (twice)
and t27c's check counts each phrase as a TestBlock named implementation / documents (see duplicate_top_level_decls -> collect_top_level_decls, bootstrap/src/compiler.rs:25529). Lab-proven by rewording only the comments: t27c check goes from 2 warnings to 0 with the spec bodies untouched.
Fix here (this issue): reword the four comment phrases so no prose contains test <identifier>; reseal the optimizer twins (the spec hash moves). The compiler-side root cause -- inline comment text being tokenized at all -- is #8581, parked under the foreign-code rule.
Refs #6063 (steward lane; found while clearing the Spec Guards stack after #8564).
Activity
seals: re-seal the optimizer twins after the comment reword (Refs #8580)
optimizer.t27: comment prose minted phantom test declarations -- rewo…