You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
actors_hw_jtag: the verdict word's base constant reads layout 2 design 59, not layout 3 design 27 #8835
Defect in #8826 (merged as #8830). An end-to-end simulation of the generated top found it, with behavioural stand-ins for STARTUPE2, BUFG and BSCANE2 and a USER1 read at 1 MHz.
Problem
VERDICT_BASE in specs/queen/actors_hw_jtag.t27 is 2779066048 (0xA5A52EC0). That word reads as layout 2, design 59. The spec and its PR say layout 3, design 27, which is 2779068096 (0xA5A536C0).
The value was typed in as one number, and the tests compared word 0 with the same constant, so nothing caught it.
Readers check only the 16'hA5A5 magic, so they would have read the word. But they would have mistaken it for a layout v2 word from a different design.
Fix
Build VERDICT_BASE from its fields: magic, layout and design.
Add a test that decodes the fields of VERDICT_BASE and of verdict_word.
Acceptance
The new test passes in t27c test-report and t27b test.
The end-to-end simulation reads a5a536fd, which decodes to magic a5a5, layout 3, design 27, with done, sig_ok, count_ok, live and ok set.
Given the VERDICT_BASE constant in specs/queen/actors_hw_jtag.t27 is defined as a single literal value, When the constant is decoded into its magic, layout, and design fields, Then the fields must read magic 0xA5A5, layout 3, and design 27 (not layout 2, design 59).
Requirements
FR-001: The VERDICT_BASE constant MUST be constructed from its constituent fields (magic = 16'hA5A5, layout = 3, design = 27) rather than a single literal.
FR-002: A test MUST be added that decodes VERDICT_BASE and verdict_word into their magic, layout, design, and status bits and asserts the expected values.
FR-003: The end-to-end simulation MUST produce a verdict word of 0xA5A536FD (magic a5a5, layout 3, design 27, done=1, sig_ok=1, count_ok=1, live=1, ok=1).
Success Criteria
t27c test-report specs/queen/actors_hw_jtag.t27 exits with exit 0 and includes the new decode test passing.
t27b test specs/queen/actors_hw_jtag.t27 exits with exit 0.
The end-to-end simulation reads verdict word a5a536fd which decodes to magic a5a5, layout 3, design 27, with done, sig_ok, count_ok, live and ok all set.
Activity
actors_hw_jtag: build the verdict word's base from its fields -- layo…