Repository navigation
t27b ledger: delete the five vacuous stubs (lsp/language, tri/utils/string, tri/utils/error, sandbox/modules, physics/lqg_entropy) #8908
Copy link
Copy link
Closed
Labels
Description
The last five pass_vacuous rows of the t27b ledger are stubs with nothing to assert, as #8766 found. This issue deletes them, as #8054 deleted 22 empty stubs. Part of the t27b ledger work (see #8326 and #6063).
| spec | what it holds | used by |
|---|---|---|
specs/lsp/language.t27 |
a TODO and an empty main() |
nothing |
specs/tri/utils/string.t27 |
a module line and two use lines |
nothing |
specs/tri/utils/error.t27 |
a broken skeleton, struct { enum : , } |
nothing |
specs/sandbox/modules.t27 |
use sandbox.session_timeout; and an assert true invariant |
nothing; architecture/graph.tri names it as a dep of sandbox.health, but it has no node there and health.t27 does not use it |
specs/physics/lqg_entropy.t27 |
prose; tests that are then true / assert true |
nothing |
git grep finds no use of any of the five modules. The only other mentions are seals, historical reports and docs.
Fix
- Delete the five specs and their 11 seals (
spec_pathmatches). - Remove their five ledger rows.
pass_vacuousrows do not count towardmax_not_pass, so the cap does not move. proofs/lean4/.../Completeness.leanholds lowerability models of three of them (physics_lqg_entropy,tri_utils_error,tri_utils_string). Remove them, and lower the floor ofcorpus_classifier_matches_lean_completenessby those 3 theorems, as proofs: drop the Lean models of the 22 spec stubs #8054 deleted (Closes #8222) #8223 did for t27b vacuous: delete 22 empty generated spec stubs (Closes #8052) #8054. None is inlean_completeness_mismatches.json.- Drop the dangling
sandbox.modulesdep fromarchitecture/graph.tri. - lqg_entropy's prose is already section 5 of
docs/nona-02-organism/physics-kepler/KEPLER-NEWTON-CHERN-SIMONS.md. Move its one missing point there (the two different origins of gamma, with its references), and point the note's spec list atspecs/physics/lqg_cs_bridge.t27, which defines and tests every quantity it named.
Boundary
- specs/lsp/language.t27
- specs/tri/utils/string.t27
- specs/tri/utils/error.t27
- specs/sandbox/modules.t27
- specs/physics/lqg_entropy.t27
- .trinity/seals/
- docs/reports/t27b_expectations.json
- proofs/lean4/Trinity/IcarusLowerable/Completeness.lean
- bootstrap/tests/icarus_lowerable.rs
- architecture/graph.tri
- docs/nona-02-organism/physics-kepler/KEPLER-NEWTON-CHERN-SIMONS.md
User Scenarios
- Given the t27b ledger contains five
pass_vacuousrows for specs that have no assertions and are not used by any module, when the five specs and their ledger rows are deleted, then the ledger no longer lists them and themax_not_passcap remains unchanged. - Given the Lean completeness proofs contain lowerability models for three of the deleted specs, when those models are removed and the floor of
corpus_classifier_matches_lean_completenessis lowered by three, then the Lean build passes with the updated theorem count. - Given
architecture/graph.tricontains a dangling dependency onsandbox.modules, when that dependency is removed, then the architecture graph no longer references the deleted spec.
Requirements
- FR-001: The five specs (
specs/lsp/language.t27,specs/tri/utils/string.t27,specs/tri/utils/error.t27,specs/sandbox/modules.t27,specs/physics/lqg_entropy.t27) MUST be deleted from the repository. - FR-002: The five corresponding
pass_vacuousrows MUST be removed fromdocs/reports/t27b_expectations.json. - FR-003: The 11 seal files matching the five spec paths MUST be deleted from
.trinity/seals/. - FR-004: The three lowerability models (
physics_lqg_entropy,tri_utils_error,tri_utils_string) MUST be removed fromproofs/lean4/Trinity/IcarusLowerable/Completeness.lean, and the floor ofcorpus_classifier_matches_lean_completenessMUST be lowered by 3. - FR-005: The dangling dependency on
sandbox.modulesMUST be removed fromarchitecture/graph.tri. - FR-006: The missing point about the two different origins of gamma with its references MUST be moved from
specs/physics/lqg_entropy.t27todocs/nona-02-organism/physics-kepler/KEPLER-NEWTON-CHERN-SIMONS.md(section 5), and the note's spec list MUST point tospecs/physics/lqg_cs_bridge.t27.
Success Criteria
git ls-files specs/lsp/language.t27 specs/tri/utils/string.t27 specs/tri/utils/error.t27 specs/sandbox/modules.t27 specs/physics/lqg_entropy.t27outputs nothing and exits 0.grep -c "pass_vacuous" docs/reports/t27b_expectations.jsonreturns a count 5 less than before (the five specific entries are absent).ls .trinity/seals/ | grep -E "lsp_language|tri_utils_string|tri_utils_error|sandbox_modules|physics_lqg_entropy"returns 0 lines and exits 0.grep -c "physics_lqg_entropy\|tri_utils_error\|tri_utils_string" proofs/lean4/Trinity/IcarusLowerable/Completeness.leanreturns 0 and exits 0.cargo test -p icarus_lowerablepasses (exit 0) and the constantcorpus_classifier_matches_lean_completenessfloor is reduced by 3.grep "sandbox.modules" architecture/graph.trireturns no lines and exits 0.grep -A2 -B2 "two different origins of gamma" docs/nona-02-organism/physics-kepler/KEPLER-NEWTON-CHERN-SIMONS.mdshows the moved prose with references, and the spec list in that note points tospecs/physics/lqg_cs_bridge.t27.
Reactions are currently unavailable
Activity
t27b ledger: delete the five vacuous stubs -- lsp/language, tri/utils…