Repository navigation
ci: remove copied helpers from STEP1/STEP2 t27 ports #9631
Description
Summary
Remove copied STEP1/STEP2 helper bodies through shared .t27 behavior. Active implementation is already assigned to the owner's Claude lane; do not start a second implementation.
Boundary
- specs/port/trinity/fpga/openxc7-synth/trinity_block_step1_top.t27
- specs/port/trinity/fpga/openxc7-synth/trinity_block_step2_top.t27
- specs/port/trinity/fpga/openxc7-synth/trinity_block_common.t27
User Scenarios
Given both published port specs, when their generated behavioral tests run after helper extraction, then STEP1 and STEP2 retain their distinct frame types and existing behavior.
Requirements
FR-001: Shared helpers MUST be implemented once in .t27 and reused.
FR-002: Public contracts, constants, assertions and existing behavioral tests MUST be preserved.
FR-003: The detector and ratchet MUST NOT be weakened; no cosmetic renaming or manual generated-code edits.
FR-004: Necessary shared-module tests MUST cover boundaries and both frame types.
Success Criteria
The eight affected duplicate groups disappear through reuse. Parser/typecheck and executable tests of both ports exit 0. The gen_w generator family remains a separate lane. Final-SHA CI must be inspected before claiming green.
Evidence
PR9622 failed check: https://github.com/gHashTag/t27/actions/runs/38751547419/job/116478946837 .
The same 12 names were reproduced by the existing CI scanner on clean master cd8a656 (exit1); eight belong to this family: weight_sign, bit_at, uart_tx_bit_at, led_state_next, led_counter_next, debug_state_bits, build_report_frame, on_comb.
Related port/policy issues: #9370, #9415, #8963. The active Claude lane selected the shared-module path listed above.
Hardware, flashing, other ports and deployments are out of scope.
Dmitrii Fedorov (@dmitrii-f-t27)
Activity
github-actions commentedon Oct 15, 2026
Closed by the issue-shape gate (specs/policy/issue_shape.t27, #7498): an issue must have the template's sections. Edit the body; an edit that passes reopens it.
- specs/x.t27); without it the Queen reserves nothing and no bee can take the issueFR-001: ... MUST ...exit 0, or a backticked commandgithub-actions commentedon Oct 15, 2026
The shape check passes now (specs/policy/issue_shape.t27); reopened.
dmitrii-f-t27 commentedon Oct 15, 2026
Coordination: the parallel codex/ci-repair-9622-9630 lane also prepared a STEP common module before discovering this lane. It will not publish a competing STEP PR; #9631 remains the publication issue. Its gen_w-family deduplication is verified separately: all eight ports retain 13/13 reference tests, and gen_w_tree passes 7/7 under reference and native (33 asserts). The STEP experiment used a parent fpga module path to avoid a hyphen in the use path; its common helper native tests passed 7/7 (49 asserts), reference/port validation is still pending. Please preserve both frame tags 0x43/0x44 and unchanged port test meaning. No duplicate-body baseline increase is allowed. Dmitrii Fedorov (@dmitrii-f-t27)