Repository navigation
ci(dupe): bless the two deliberate put copies in the NMSE run harness (Closes #10025) - #10027
Merged
Merged
Conversation
…Closes #10025) #10021 landed specs/benchmarks/gf16_bfloat16_nmse_run.t27 without moving the duplicate-body ledger. Its put_lit and put_range repeat put_msg and put_range in specs/policy/own_language.t27, so the Duplicate Body Ratchet has been red on master since cc80a30. The copies are deliberate. The harness lowers through t27c gen-c into one C file, and the committed manifest records the spec's own sha256 as x_extension.harness_sha256. Editing the spec to reuse the existing functions would leave that manifest pointing at a file that is no longer in the tree. So the ledger moves instead, written by `python3 tools/dupe_scan.py --bless` on the Railway lab at cc80a30: two added lines, put_lit 2 and put_range 2. No spec changes. Verified on the lab: dupe_scan exits 1 before the bless and 0 after; --self-test exits 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10025
What
The Duplicate Body Ratchet has been red on master since #10021 (cc80a30). It was green at efe3c94.
specs/benchmarks/gf16_bfloat16_nmse_run.t27definesput_litandput_range, whose bodies matchput_msgandput_rangeinspecs/policy/own_language.t27, and the ledger was not moved in that commit.This moves the ledger:
tools/duplicate_bodies_baseline.txtgainsput_lit 2andput_range 2, written bypython3 tools/dupe_scan.py --bless. No spec changes.Why bless instead of reuse
t27c gen-cinto one C file for the run driver.bench/results/nmse-railway-x86_64-0x2545F4914F6CDD1D-2026-10-17.jsonrecords the spec's own sha256 asx_extension.harness_sha256. Any edit to the spec would leave that manifest pointing at a file that is no longer in the tree.Verification (Railway lab, master cc80a30)
python3 tools/dupe_scan.py: exit 1 before the bless, exit 0 after.python3 tools/dupe_scan.py --self-test: exit 0.652580c2...7db3, the same on the lab and in this commit. The diff is 2 added lines.Not in this PR
Spec Guards, Seal Coverage and cli-tri were already red on master at efe3c94 and 2f39502, before #10021. cli-tri fails because
cli/tri/src/gates.rs:9012usesinclude_str!on.github/workflows/brain-seal-refresh.yml, which master no longer has (removed in #9117).🤖 Generated with Claude Code