Skip to content

seals: reseal the four fpga/board specs #10014 edited (Closes #10052) - #10053

Merged
gHashTag merged 1 commit into
masterfrom
fix/reseal-fpga-boards
Oct 17, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/reseal-fpga-boards

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Closes #10052

What

#10014 (2f39502) edited four specs without resealing them, so Spec Guards and Seal Coverage went red on master and
on every open PR:

  • specs/boards/xc7a100t_minimal.t27: BoardMinimalXC7A100T.json, boards_BoardMinimalXC7A100T.json
  • specs/boards/wukong_v1.t27: boards_BoardWukongV1.json
  • specs/fpga/placement.t27: Placement.json, fpga_Placement.json
  • specs/fpga/stdlib.t27: Stdlib.json, fpga_FpgaStdlib.json, fpga_Stdlib.json

The diff holds only these 8 tool-written .trinity/seals/*.json files. No spec, no code, and no baseline entry.

How

On the Railway lab, in a fresh clone of master at d03afb0, with t27c and tri built from that tree:

t27c seal <spec> --save    # x4; updates the twin seal files that name the same spec
tri seals sync-twins       # twinned specs already consistent 491, seal files written 0

--update-baseline was not used. The check says baselining gen-drift is the wrong repair.

Evidence (lab)

python3 tools/check_seal_currency.py      # before: STALE generated-code hash : 8
  STALE generated-code hash     : 0       # after, rc=0
python3 tools/check_seal_coverage.py
  OK: 2425 seals, 2303 hold, 122 known-broken (...) listed in seal_baseline.txt

Test counts in the new seals: Placement 14/14, Stdlib 17/17, BoardMinimalXC7A100T 23/23, BoardWukongV1 15/15,
all with 0 failed and 0 vacuous.

Not fixed here

cli-tri is also red on master: cli/tri/src/gates.rs:9012 uses include_str! on
.github/workflows/brain-seal-refresh.yml, which #9117 deleted. Fixing it means editing Rust, which needs
owner-approved-foreign; see #10052.

🤖 Generated with Claude Code

#10014 changed specs/boards/xc7a100t_minimal.t27, specs/boards/wukong_v1.t27,
specs/fpga/placement.t27 and specs/fpga/stdlib.t27 without resealing, so
check_seal_currency reported 8 STALE seals and Spec Guards and Seal Coverage
went red for every PR.

Written by `t27c seal <spec> --save && tri seals sync-twins` on the Railway
lab at d03afb0. No --update-baseline. Lab: STALE generated-code hash 0,
check_seal_coverage OK.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-17 17:38:35 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 49
PRs with All Checks Green 1
READY 0
FAILING 49
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 49 + 0 + 0 = 49, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e769ef021713 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag enabled auto-merge (squash) October 17, 2026 17:39
@gHashTag
gHashTag merged commit decd041 into master Oct 17, 2026
23 of 25 checks passed
@gHashTag

Copy link
Copy Markdown
Owner Author

Two checks fail on this PR. Neither comes from its diff, which holds only 8 seal JSON files:

Once this PR merges, Spec Guards and Seal Coverage should go green on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec Guards and Seal Coverage red on master: 8 seals stale after #10014 edited four fpga/board specs

1 participant