Repository navigation
ledger(dupe): record the four bodies suite_ledger_steward copies from the t27b steward (Closes #10216) - #10217
Conversation
… the t27b steward (Closes #10216) #10208 added specs/ci/suite_ledger_steward.t27 and specs/jobs/suite_ledger_steward.t27. They repeat effect_wanted, run_starts_job, step_ef and writes_the_repo from the t27b ledger steward specs, so the Duplicate Body Ratchet has been red on master since 27efeba and on every open PR. tools/duplicate_bodies_baseline.txt is rewritten by `python3 tools/dupe_scan.py --bless` on the Railway lab at master d9e0c6c: four lines added, none removed, no other count moves. Afterwards dupe_scan.py exits 0 ("ok: no new duplicate body"). Reusing the t27b functions with a `use` instead is left to #10208's owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![tri-claw[bot]](https://avatars.githubusercontent.com/in/5166765?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewer bee verdict for head b460198c1c3a5bbe43ec8a4c63adb9317edf3052 (tools/bees/reviewer.py, zai glm-4.7-flash, 6 turns, 40 s; then glm-4.5-flash, 5 turns, 50 s).
BEE-VERDICT: APPROVE
summary: Adds exactly the four duplicate bodies to the baseline via --bless, satisfying all requirements
criterion: FR-001: The ledger MUST be written by tools/dupe_scan.py --bless, not by hand -- met -- evidence: brief:line31
criterion: FR-002: The PR MUST change exactly one file, with 4 lines added and 0 removed -- met -- evidence: brief:line78
criterion: FR-003: No existing group's count MUST change -- met -- evidence: brief:lines31-32
criterion: Success criterion 1: git diff --numstat prints 4 0 -- met -- evidence: diff:line78
criterion: Success criterion 2: duplicate-bodies concludes success -- met -- evidence: brief:lines31-32
discounted-check: coverage -- failure existed on master c6f745c before the change (brief:line85)
Evidence
Now let me verify the acceptance criteria against the brief and diff:
Analysis
1. Does the change do what issue #10216 asks?
Goal of issue #10216: Turn the Duplicate Body Ratchet green by recording that four bodies (effect_wanted, run_starts_job, step_ef, writes_the_repo) are duplicated from the t27b steward specs.
Acceptance criteria from brief:
- FR-001: The ledger MUST be written by
tools/dupe_scan.py --bless, not by hand — MET: brief shows "blessed: 162 group(s), 645 body(ies)" (line 31) - FR-002: The PR MUST change exactly one file, with 4 lines added and 0 removed — MET: diff shows
tools/duplicate_bodies_baseline.txt | 4 ++++(line 78) - FR-003: No existing group's count MUST change — MET: brief shows same blessed count, diff shows only additions (lines 18-21, 31-32)
- Success criterion 1:
git diff --numstat origin/masterprints4 0 tools/duplicate_bodies_baseline.txt— MET: diff clearly shows 4 additions, 0 deletions - Success criterion 2:
duplicate-bodiesconcludes success — MET: brief shows "blessed: 162 group(s), 645 body(ies)" and after bless, "exit 0, ok: no new duplicate body, and none of the known groups grew."
The change adds exactly the four lines requested:
+effect_wanted 2(diff line 9)+run_starts_job 2(diff line 17)+step_ef 2(diff line 25)+writes_the_repo 2(diff line 33)
Spec integrity: No spec changes. The brief explicitly states "No spec changes" (line 24).
2. Red checks
Only one red check: coverage
Evidence from brief (line 85): "on master: master c6f745c: queued"
The coverage failure is on seal coverage for policy_PolicyOwnLanguage.json, which is about seal sealing, not about duplicate bodies. This failure existed on master before the PR (the brief shows the same check was "queued" on master commit c6f745c). The duplicate-bodies check itself passes with exit code 0 (brief lines 31-32).
Second, independent review (glm-4.5-flash): APPROVE -- Successfully updates duplicate bodies ledger with four copied bodies from suite_ledger_steward specs
tri-claw
Bot
added
the
bee-reviewed
1 participant
Closes #10216
#10208 added
specs/ci/suite_ledger_steward.t27andspecs/jobs/suite_ledger_steward.t27. They repeat four bodies from the t27b ledger steward specs:effect_wanted,run_starts_job,step_efandwrites_the_repo. Since 27efeba the Duplicate Body Ratchet has been red on master and on every open PR, for example #10211 (run 39097511524).Change
tools/duplicate_bodies_baseline.txtis rewritten bypython3 tools/dupe_scan.py --blesson the Railway lab at master d9e0c6c. The bless adds four lines and removes none, and no other count moves:No spec changes. The better long-term fix is to reuse the t27b steward's functions with a
use, and that is left to the owner of #10208.Evidence (Railway lab, master d9e0c6c)
dupe_scan.pybeforedupe_scan.py --blessdupe_scan.pyafter5d7898d4a173...3af3948on both🤖 Generated with Claude Code