Repository navigation
bootstrap: delete the dead watch command; frontier --watch is the hot reload (Closes #10238) - #10240
Merged
Merged
Conversation
… reload (Closes #10238) The old watch command printed the changed files, slept and continued before its suite call, so a save never reran anything, and the one run it made called a hard-coded ./bootstrap/target/release/t27c (bootstrap/ is a workspace member, the binary is ./target/release/t27c). Nothing in the tree calls it; `tri hot watch` runs the frontier --watch loop (specs/verified/watch.t27). Removes the Watch variant, both dispatch arms and run_watch: 106 hand-written lines lost, none gained. Measured on the Railway lab: the old command now exits 2, and the frontier --list output on the unchanged tree is byte-identical to the base binary's (reused 1394 of 2227). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10238. Epic #8095 (hot reload), ledger #8737. Step 3 of the change-only inner loop.
What
Deletes the dead
watchsubcommand: theWatchvariant, both dispatch arms (the sync and the asyncmain) andrun_watchwith its two inner helpers. 106 hand-written lines lost, 0 gained.Why
Read from the code, the command could not do what its name says:
continues before the suite call, so a save reruns nothing. Only the first scan ran the suite../bootstrap/target/release/t27c suite.bootstrap/is a workspace member, so the binary is./target/release/t27c; on a normal checkout it fails with "suite error".specs/andcompiler/(a directory that does not exist) and reran the whole suite.Nothing in the tree names it (no script, workflow, skill or
triaction);tri hot watchrunsfrontier --watch(specs/verified/watch.t27, #8737 H5), which is the real hot reload.Verified on the Railway lab
cargo build --release -p t27c -j 6: builds clean.--helpno longer lists it.t27c frontier --liston the unchanged tree: 0 differing lines against the base binary (frontier: reused 1394 of 2227 (626 permille); rebuild: spec 52 closure 135 toolchain 29 config 0 verdict 153 missing 464).bootstrap/src/test_report.rsis untouched.foreign-budget,own-language) pass on the commit.🤖 Generated with Claude Code