Repository navigation
master red: trinity_fpga_adapter width repaired at the cause, hex_val merged (Closes #10382) - #10386
Merged
Merged
Conversation
…op its width-ledger line (Refs #10382) Consts is four str fields, a str has no bit representation, so the local var c: Consts was a 0-bit register and range_decl printed [4294967295:0]. self_check now passes good_consts() inline. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…10382) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 18, 2026 10:44
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10382
Two required checks were red on master (b2fbb75 / #10370 through 9969315). #10373 turned them green by hand-adding a width-ledger line and blessing 20 duplicate names. This PR repairs what it can and says plainly what it leaves.
1. Verilog widths: fixed at the cause
specs/port/tools/trinity_fpga_adapter.t27self_checkheld a localvar c: Consts.Constsis a struct of fourstrfields; astrhas no bit form, so the packed width is 0 andrange_declprinted[0 - 1 : 0]as[4294967295:0]. The spec reached the gate only when #10370 made it compile.good_consts()is passed directly);self_checkreturns the same values and all 6 tests still pass.tools/verilog_width_baseline.txtloses the line claw: suggest_feed -- a spec that t27c fmt would reformat becomes a suggestion review on the PR (Closes #10365) #10373 added. The ledger gains nothing.4294967295;check_verilog_widths.py --requireprintsOK: 4 known, 0 new.t27c seal --save.2. Duplicate bodies: one group merged, the rest left with a reason
hex_val(url.t27 and net.t27 were byte-identical) is merged:specs/tri/net/url.t27now hasuse tri::net::net;and no local copy. Tests: url 16/16, net 15/15, 0 vacuous. The TriUrl seals (two files naming the spec) were regenerated by t27c.hex_val 2is removed fromtools/duplicate_bodies_baseline.txtby hand, so the file keeps its shape.dupe_scan.pyexits 0.The other groups are NOT merged here, and nothing was blessed again. I read each pair: they are the same text over module-local types, state or constants, so a
usewould either pull in a second module's types or clash on names (two imports defining one function name are reported ambiguous).A follow-up that gives byte helpers a single home (as #10318 did for claw text) would retire most of these. It needs a design decision on a shared text type, so it is out of this PR. Note that
dupe_scan.py --blessrewrites the ledger and drops comments, so the reasons live here and in #10382, not in the file.Checks (all on the Railway lab, none on the Mac)
python3 tools/dupe_scan.py: ok, exit 0python3 tools/check_verilog_widths.py --require: OK: 4 known, 0 newt27c seal-audit: no entry for the touched specsOnly
.t27, seals and ledgers changed.🤖 Generated with Claude Code