Repository navigation
t27f token_floor: expose only the pixels a splat visited; the empty scene's bytes are computed once (Closes #10407) - #10411
Merged
Conversation
…cene's bytes are computed once (Closes #10407) The empty scene's light depends on the pixel, not on the frame. main now computes the background bytes and each row's key, glint and fade factors once. A row gives a pixel the empty scene's light on the first splat visit, marks it dirty, and exposes only dirty pixels; every other pixel is copied from the cached bytes. Splat order and every float sum are unchanged, so frames are byte-identical (sha256 7e0c6662...391e07, one process and 48 shards). New pure helpers row_key, row_glint, row_fade, light_byte with two tests asserting exact values, including bytes read off frame 0. Lab, -O ReleaseSafe -lc: one process 32.8 s / 33.2 s -> 18.8 s / 17.9 s. test-report 28/28, 0 vacuous; resealed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10407
What
After #10402, most of a token_floor frame went to work that does not depend on the frame: for every pixel of every frame the raster built the empty scene's light (
back_lightx tint) and exposed it (quantize(expose(...)), threeexpcalls a pixel), touched by a splat or not.mainnow computes the empty scene's bytes (bgq, 6,220,800 bytes) and each row's key, glint and fade factors (kya,gya,fra) once per process.bgq. A visit that adds nothing leaves the light unchanged, so a dirty pixel with no contribution writes the same byte the cache holds.row_key,row_glint,row_fade,light_byte, with two tests asserting exact values: the row helpers rebuildbackdrop(x, y)on a 275 x 84 sweep with 0 mismatches, andlight_bytereproduces bytes read off frame 0 of the t27f token_floor: a per-frame row index, so each raster row visits only the splats that touch it (Closes #10391) #10402 reel (corners, the floor line at y 1639.5 / 1640.5).Verification (Railway lab,
-O ReleaseSafe -lc)7e0c6662ddbf84a0a424c0aa119420eb34f90b0decec6e0c05753b2d37391e07TF_SHARD/TF_SHARDS) concatenated, run 1 and 27e0c6662ddbf84a0a424c0aa119420eb34f90b0decec6e0c05753b2d37391e07Timing, interleaved A/B with the #10402 binary on the same lab (load 49-78 on 48 cores):
t27c test-report specs/t27f/token_floor.t27: 28/28 pass, 0 vacuous..trinity/seals/t27f_token_floor.json(spec_hash2ac0e9d3...); the Zig t27c generates from the committed spec is the build that was timed..t27and the seal change; no other language touched.🤖 Generated with Claude Code