Repository navigation
fix(dupe-bodies): rem_int calls arena_heap's is_pow2 instead of copying it (Refs #10431) - #10453
Merged
Merged
Conversation
…ng it (Refs #10431) cc598ec (#10431) added `ri_is_pow2` to specs/tri/t27b/conformance/rem_int.t27 as a byte-for-byte copy of specs/ml/arena_heap.t27's `is_pow2`. That is a new duplicate body no ledger holds, so the Duplicate Body Ratchet has been red on master since 89254d2. rem_int now says `use ml::arena_heap;` and asserts on `is_pow2` itself, the way libm_logf.t27 uses tri::t27b::libm. The 7 asserts are unchanged; the ledger is not touched (the corpus goes 686 -> 684 bodies, 197 -> 196 groups). Seal of rem_int re-saved through `t27c seal --save` (its closure now holds arena_heap). On the Railway lab: dupe_scan ok, `t27c check` ok, `t27c test-report` 8/8 pass (12 runtime asserts in the corpus test), and `t27b build --elf` accepts the file. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 18, 2026 12:27
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Master's "Duplicate Body Ratchet" has been red since 89254d2:
a body written under is_pow2 is now copied [2] time(s) and was in no ledger.Cause: cc598ec (#10431) added
ri_is_pow2tospecs/tri/t27b/conformance/rem_int.t27as a byte-for-byte copy ofspecs/ml/arena_heap.t27'sis_pow2.Fix
Remove the copy instead of ledgering it.
rem_int.t27now hasuse ml::arena_heap;and asserts onis_pow2directly, the same waylibm_logf.t27usestri::t27b::libm. The 7 asserts are unchanged. The duplicate-body ledger is untouched (corpus 686 -> 684 bodies, 197 -> 196 groups).The seal of
rem_intwas re-saved witht27c seal --save(no--force); its closure now holdsarena_heap.Verified on the Railway lab
python3 tools/dupe_scan.py: ok, no new duplicate body and no known group grewt27c check: OKt27c test-reportonrem_int.t27: 8/8 pass, 0 vacuous (12 runtime asserts in the corpus test);arena_heap.t2710/10t27b build --elfacceptsrem_int.t27(the lab is x86_64, sot27b testitself runs in the arm64t27b nativeCI job)Refs #10431
🤖 Generated with Claude Code