Repository navigation
Conversation
… clamp01 instead of copying it (Refs #10451) 7552b89 (#10452) left three byte-identical `clamp01` bodies, in specs/t27f/pbr_sphere.t27, token_floor.t27 and token_floor_scenes.t27. No ledger holds that group, so the Duplicate Body Ratchet has been red on master since 7552b89, and every open PR shows the red. pbr_sphere's `clamp01` becomes `pub`. token_floor and token_floor_scenes now say `use t27f::pbr_sphere::clamp01;` and drop their copies, the way token_floor already uses pbr_sphere's `shade`. Neither module imported anything that imports them back, so no cycle. The ledger is not touched. On the Railway lab at 982894c: - dupe_scan: ok, 684 bodies in 196 groups, none new and none grown. - `t27c check`: ok for all four t27f token_floor specs. - `t27c test-report`: pbr_sphere 13, token_floor_scenes 11, token_floor 34 and token_floor_mux 14 tests pass, 0 vacuous. - Seals of pbr_sphere, token_floor_scenes and token_floor were re-saved through `t27c seal --save`. All four pass `seal --verify` (token_floor_mux needed no change). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Owner
Author
|
Superseded by #10471, which makes the same clamp01 dedupe (token_floor and token_floor_scenes use pbr_sphere's clamp01) and also adds the t27b ledger rows. Both PRs rewrite token_floor_scenes.t27 and the same three seals, so only one can land cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7552b89 (#10452) left three byte-identical
clamp01bodies, inspecs/t27f/pbr_sphere.t27, token_floor.t27 and token_floor_scenes.t27. No
ledger holds that group, so the Duplicate Body Ratchet has been red on
master since 7552b89, and every open PR shows the red.
pbr_sphere's
clamp01becomespub. token_floor and token_floor_scenesnow say
use t27f::pbr_sphere::clamp01;and drop their copies, the waytoken_floor already uses pbr_sphere's
shade. Neither module importedanything that imports them back, so no cycle. The ledger is not touched.
On the Railway lab at 982894c:
t27c check: ok for all four t27f token_floor specs.t27c test-report: pbr_sphere 13, token_floor_scenes 11, token_floor 34and token_floor_mux 14 tests pass, 0 vacuous.
through
t27c seal --save. All four passseal --verify(token_floor_mux needed no change).
🤖 Generated with Claude Code