Repository navigation
fix(t27f): reuse one clamp01 from pbr_sphere instead of three copies - #10477
Merged
Merged
Conversation
…(Refs #10416) pbr_sphere exports clamp01; token_floor and token_floor_scenes import it. Seals of the three specs refreshed. No duplicate-body baseline change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 18, 2026
Merged
Contributor
This was referenced Oct 18, 2026
Merged
gHashTag
enabled auto-merge (squash)
October 18, 2026 14:07
gHashTag
added a commit
that referenced
this pull request
Oct 18, 2026
…amp01 dedupe, keep this branch's side Refs #10469 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #10416
Why
duplicate-bodiesis red on every PR (for example #10470).clamp01had three identical bodies inspecs/t27f:token_floor.t27(from #10325), andpbr_sphere.t27andtoken_floor_scenes.t27(both from #10452). The third copy made a known group grow, which the Duplicate Body Ratchet rejects. The check had been cancelled by concurrency on the master commits in between, so the regression went unnoticed.What
pbr_sphere.t27:clamp01becomespub fn. Body unchanged. It is a leaf module, so no import cycle.token_floor_scenes.t27andtoken_floor.t27: the local copy is deleted anduse t27f::pbr_sphere::clamp01;is added (token_flooralready imports frompbr_sphere).t27c seal --saveon the lab (zig 0.16.0). Test counts are unchanged;token_floor_scenesgainspbr_spherein its closure.Specs: 4 lines added, 13 removed. No baseline was blessed:
tools/duplicate_bodies_baseline.txtis untouched.How to check
python3 tools/dupe_scan.pyreports no new duplicate body and no grown group, and--name clamp01finds one place (specs/t27f/pbr_sphere.t27).🤖 Generated with Claude Code