Skip to content

fix(t27f): reuse one clamp01 from pbr_sphere instead of three copies - #10477

Merged
gHashTag merged 1 commit into
masterfrom
clamp01-reuse-10416
Oct 18, 2026
Merged

gHashTag merged 1 commit into
masterfrom
clamp01-reuse-10416

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Refs #10416

Why

duplicate-bodies is red on every PR (for example #10470). clamp01 had three identical bodies in specs/t27f: token_floor.t27 (from #10325), and pbr_sphere.t27 and token_floor_scenes.t27 (both from #10452). The third copy made a known group grow, which the Duplicate Body Ratchet rejects. The check had been cancelled by concurrency on the master commits in between, so the regression went unnoticed.

What

  • pbr_sphere.t27: clamp01 becomes pub fn. Body unchanged. It is a leaf module, so no import cycle.
  • token_floor_scenes.t27 and token_floor.t27: the local copy is deleted and use t27f::pbr_sphere::clamp01; is added (token_floor already imports from pbr_sphere).
  • Seals of the three specs refreshed with t27c seal --save on the lab (zig 0.16.0). Test counts are unchanged; token_floor_scenes gains pbr_sphere in its closure.

Specs: 4 lines added, 13 removed. No baseline was blessed: tools/duplicate_bodies_baseline.txt is untouched.

How to check

python3 tools/dupe_scan.py reports no new duplicate body and no grown group, and --name clamp01 finds one place (specs/t27f/pbr_sphere.t27).

🤖 Generated with Claude Code

…(Refs #10416)

pbr_sphere exports clamp01; token_floor and token_floor_scenes import it.
Seals of the three specs refreshed. No duplicate-body baseline change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-18 13:43:47 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 49
PRs with All Checks Green 1
READY 0
FAILING 49
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 49 + 0 + 0 = 49, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=fad12492937a != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant