Repository navigation
test(claw): kill the real check_latest.t27 mutation survivors (#10739) - #10741
Merged
Merged
Conversation
Three tests: run ids of 0 and 20 digits, the 1024-row cap in both readers, and a blank line before a re-run at the cap. 41 -> 46 of 51 mutants; the 5 left are equivalent. Reseals CheckLatest and RequiredRed, which still cited check_state.t27 from before #10726. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 19, 2026 00:48
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds tests to
specs/claw/check_latest.t27, the TRI CLAW reader that lets a re-run supersede the run it replaces. A mutation sweep (#10739) showed what its tests let through. Only tests and one test helper change; production code does not.a_run_id_is_one_to_twenty_digitsthe_row_cap_reads_1024_rows_and_refuses_the_nextlatest_countsand inis_superseded; neither had a testa_blank_line_does_not_push_a_rerun_past_the_capis_supersededonly, so a re-run at row 1024 stopped supersedingThe cap fixture fills its rows with commit statuses.
is_supersededreturns at once for those, so the 1025-row test runs in well under a second.The five that stay are listed with a reason each in #10739.
Also in this change: two stale dependency hashes
claw_ClawCheckLatest.json. The seal diff changed the recorded hash ofcheck_state.t27, although this PR does not touch it. A scan of every seal on master found two claw seals still citingcheck_state.t27from before test(claw): kill the real check_state.t27 and merge_lane.t27 mutation survivors #10726: CheckLatest and RequiredRed.claw_ClawRequiredRed.jsonis resealed too, since it importscheck_latest.t27andcheck_state.t27. This is tool-written data. The diff changes only those two dependency hashes andsealed_at.check_state.t27predated test(claw): kill the real check_state.t27 and merge_lane.t27 mutation survivors #10726. Lesson: reseal from a tree you have just reset toorigin/master. The same scan finds 152 stale dependency entries in 131 seals outsidespecs/claw, most forspecs/base/types.t27. That belongs to the lanes that own those seals; it is recorded in seal --verify never checks dependency hashes; 21 claw seals record stale ones #10727, whereseal --verifystill does not check dependencies.Verification (Railway lab, master 2520ee1)
test-reportand t27b: 14 of 14 (was 11), 0 vacuous passes.gen-c: the 7 committedgen/c/claw/*.cfiles are byte-identical. check_latest has no committed C.seal --savefor the two seals, thenseal --verifyoverspecs/claw/*.t27plusspecs/verified/gen_file_check.t27: 32 of 32..trinity/seals/claw_*.jsonfinds 0 entries after this change.Closes #10739.
🤖 Generated with Claude Code