Repository navigation
analog: VACASK as a second reference simulator: comparator decision time within 0.125 ps and DAC within 2e-15 V against ngspice-47 and the closed form - #11133
Merged
Conversation
…ive DAC (M4a) Two netlists in VACASK's own syntax, run on the remote host next to the ngspice decks they repeat (sar_cmp_psp_real.cir, sar_cdac_half.cir), with the same PSP103 OSDI file as ngspice: the golden subcircuits are translated at run time and never vendored. Data only; the comparison spec follows. Updates #10911 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…or and the capacitive DAC A comparison spec pinning what VACASK 0.3.4.dev3 and ngspice-47 measured on the same circuits with the same compiled PSP103 file (decks in specs/analog/decks/vacask_*.sim): the golden comparator's decision time agrees to 0.125 ps (0.024 %), its resolution time to 0.065 ps, all 28 winners, the top's flip point to 46 units of 2^-24 V, the DAC at 16 codes to 1.4e-12 V; our models are the 98 and 155 times too fast that sar_comparator_psp.t27 says, now against two simulators. A stated tolerance checked from both sides and six negative controls (a changed integrator, a wrong start, moved pins, exchanged inputs). t27c test-report: 7 tests, 0 FAIL, 0 vacuous. Closes #10911 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ime within 0.125 ps and DAC within 2e-15 V against ngspice-47 and the closed form (Closes #10911) Merge of master plus sealing, gates run on the merged tree with t27c from master: tests clean with vacuous passes 0, seal --verify MATCH, tri types ratchet CLEAN, dupe_scan failure set a subset of master's. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 19, 2026 19:09
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10911
analog: VACASK as a second reference simulator: comparator decision time within 0.125 ps and DAC within 2e-15 V against ngspice-47 and the closed form
Gates run on the merged tree (t27c from master): 1 spec(s) with tests clean and vacuous passes 0, seal --verify MATCH, tri types ratchet CLEAN, dupe_scan failure set a subset of master's (inherited red).
TEST specs/analog/vacask_compare.t27 tests=[7] fail=[0] vacuous=[0]
SEAL specs/analog/vacask_compare.t27 :: all hashes MATCH
TYPES RATCHET: CLEAN
DUPE failing=0 extra-vs-master=[]
🤖 Generated with Claude Code