Repository navigation
t27b checked: test blocks for 9 misc specs (basics/benchmarks/docs/lsp/mesh/multipath/sandbox/traffic) (Closes #8474) - #8539
Merged
Merged
Conversation
…8474) #8499 closed #8474 carrying three defects onto master; this repairs them and completes the one spec it left vacuous: - specs/mesh_routing.t27: n1_finite(4294967295) wraps to 0 and the flag reads false, so the merged "assert wrapped_result == true" failed the reference pipeline; it now asserts false. - specs/benchmarks/bench_main.t27 and specs/benchmarks/ternary_vs_binary.t27: the merged asserts sat inside fenced bodies whose constructs t27b cannot lower (anonymous struct, f32 array literal), leaving both specs blocked. The fenced tests keep their comment-only bodies and each file gains one run-time test pinning the per-weight sizes / the mantissa widths. - specs/lsp/language.t27: the "assert true" placeholder is removed; a stub with nothing assertable is out of scope, not a fake test. - specs/basics/24_tri_commands.t27: gains the run-time test the issue asked for and never got -- the command tables read through run-time indices. Refs #8474 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 10, 2026 11:58
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the defects #8499 left on
masterwhen it closed #8474, and completes the one spec of the nine it left vacuous. Every file was verified on both compilers before this PR was opened: the reference (t27c test-report, t27c + zig) and the t27b JIT (aarch64 build under qemu-user).specs/mesh_routing.t27-- the merged test assertedn1_finite(u32 max) == true; the wrapping+1gives0, the flag reads false, and the reference pipeline failed the file on master. It now asserts false. t27b: pass, 2 runtime asserts; reference: pass, 2 runtime asserts, 0 vacuous.specs/benchmarks/bench_main.t27-- the merged asserts sat inside fenced bodies whose constructs t27b cannot lower (anonymous struct), which left the spec blocked on the t27b side. The fenced tests keep their comment-only bodies (the bench stays, per the issue) and one new run-time test pins the per-weight size table:32 / 2 == 16and f16 soft == gf16 soft == 16. t27b: pass, 2 runtime asserts.specs/benchmarks/ternary_vs_binary.t27-- same unblocking; one new run-time test pins the quantization mantissa widths: FP16 10 - BF16 7 == 3, and BF16 keeps the narrower mantissa. t27b: pass, 2 runtime asserts.specs/lsp/language.t27-- the mergedassert trueplaceholder is removed. A module stub with nothing assertable is out of scope for t27b checked: test blocks for 9 specs in specs/basics, specs/benchmarks, specs/docs, specs/lsp, specs/mesh_routing, specs/multipath_router, specs/sandbox, specs/traffic_animator #8474, not a fake test.specs/basics/24_tri_commands.t27-- the one spec of the nine stillpass_vacuous: gains a run-time test readingOWN_COMMANDSandPASSED_TO_T27Cthrough run-time indices, so the lookups are not folded away. t27b: pass, 2 runtime asserts.Already healthy on master and untouched here:
specs/multipath_router.t27andspecs/traffic_animator.t27(the merged tests run 3 and 2 runtime asserts on t27b) andspecs/docs/system.t27(2 runtime asserts since #6623). Out of scope because nothing in them is assertable without inventing content:specs/lsp/language.t27,specs/sandbox/modules.t27.Closes #8474
🤖 Generated with Claude Code