Repository navigation
Generated simulation step, heat map and animation stats index past arrays for out-of-range counts #412
Description
Three more generated functions index past their array for an out-of-range count. Same class as #410, found while fixing it; they were not listed there, so #411 leaves them alone.
Reproduced on fix/bounds-410 (da49268, PR #411) with Rust 1.96.0, by calling the generated gen/rust modules directly:
| Function | Input | Result |
|---|---|---|
network_simulator::run_simulation_step |
event_count = 129 |
index out of bounds (MAX_EVENTS = 128) |
traffic_animator::generate_traffic_heat_map |
packet_count = 65 |
index out of bounds (MAX_PACKETS = 64) |
traffic_animator::calculate_animation_stats |
frame_count = 1201 |
index out of bounds (MAX_FRAMES = 1200) |
generate_traffic_animation passes its count to generate_traffic_heat_map, so it inherits the hazard.
Boundary:
- The fix goes in
specs/network_simulator.t27andspecs/traffic_animator.t27, with the pinned t27c regeneration of all three backends. Generated files are not edited by hand. - Public argument and return types stay unchanged.
- Builds on fix(specs): bound simulation and layout loops to their arrays #411 (same specs), so it starts after fix(gen): compile all 102 generated Rust modules and gate the corpus #409 and fix(specs): bound simulation and layout loops to their arrays #411.
Scenarios:
- A count above the array length is clamped to it, as in fix(specs): bound simulation and layout loops to their arrays #411. The spec documents what the returned fields report.
- In-range counts return the same values as before.
Requirements:
- A
testblock in each spec covers the boundary inputs above. tests/gen_rust_bounds.rs(from fix(specs): bound simulation and layout loops to their arrays #411) gains the same inputs againstgen/rust.
Success criteria:
- Every input in the table returns a defined value in Rust, C and Zig.
- The drift, Zig, C, Icarus, typecheck-warning-ratchet and
gen_rust_corpus_compilesgates stay green.
Refs #410
Dmitrii Fedorov (@dmitrii-f-t27)
Activity