Repository navigation
ci: run-syntax gate does not read composite actions (.github/actions) #854
Description
What is missing
tools/check_run_syntax.py reads .github/workflows/*.yml only. The gate's workflow is triggered by .github/workflows/** and the tool itself. So the run: steps of a composite action under .github/actions/*/action.yml are not parsed by anything, and a change to an action alone does not even start the gate.
This matters from #852 on. That PR adds the first composite action here, .github/actions/openxc7-chipdb. Its three run steps are what 53 FPGA workflows now execute.
Fix
- Glob
.github/actions/*/action.yml(andaction.yaml) next to the workflows. - When
runs.usingiscomposite, walkruns.steps. Composite steps must name ashell:, soshell_oftakes it from the step, with no job or workflow defaults. - Add
.github/actions/**to bothpaths:lists inrun-syntax-gate.yml. - Add a self-test case: an action whose run step has an unbalanced quote must fail.
Evidence so far
- For fix(ci): key the chipdb cache on the openXC7 image so it can hit #852 the action's run steps were checked by hand: they were extracted and
shellcheck -s bashwas clean on all three. Nothing in CI checks them.
Not measured
- Whether other gates (
undefined-outputs,paths,tee-pipefail) read composite actions either. Each of them should be checked the same way.
Part of #851.
Activity
gHashTag commentedon Oct 5, 2026
Fix is up as #894 (stacked on #893).
has_actions = True) is equivalent"planted in the action's last stepOne item from the fix list moved:
.github/actions/**inrun-syntax-gate.yml'spaths:is in #852 (0c5f415), not #894. On main no tracked file matches it yet, and the workflow-path gate rejects that entry (audit_workflow_paths.pyrc 1 with it, rc 0 without).Found on the way, also fixed in #852 (0c5f415): 46 workflows call
openxc7-chipdb, and none of their triggers covered.github/actions/(46 of 46 push filters, nopull_requesttrigger at all). An action-only change ran nothing.ax7203-led-onehot.ymlnow runs on a PR or a main push that touches the action.Still open from "Not measured":
tools/check_tee_pipefail.pyreads workflows only. In an action,shell: bashalready carries-o pipefail, so the gap isshell: shor a custombash {0}with| tee; no action here has one today.🤖 Generated with Claude Code
ci(tools): parse the run steps of composite actions in the run-syntax…