Repository navigation
Conversation
brain-health-report ran on always(), required all six needs to be `success`, and otherwise exited 1 and posted "CRITICAL: Brain Health Below Threshold ... cannot be merged". A cancelled need is not `success`, so a run replaced by a newer push turned into DAMAGE: run 37228527559 on #870 (stress test cancelled by the next push, report red 12 minutes later, comment at 21:10:18Z), while the replacing run 37234155119 was green throughout. !cancelled() keeps the report running after a failed need and skips it only when the workflow run was cancelled. Of the 10 job-level always() jobs on main this is the only one that tests for `success`; the fpga-ci and fpga-regression summaries exit only on `failure`. Closes #881. Part of #851. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
X Brain Health CheckScore: 100.0/100 X Brain is above merge threshold |
🧪 Brain Stress Test ResultsScore: not measured (no stress test prints a Score: line) X Stress test passed |
This was referenced Oct 4, 2026
dmitrii-f-t27
force-pushed
the
ci/report-not-on-cancel
branch
from
October 10, 2026 00:42
52793eb to
facf048
Compare
dmitrii-f-t27
pushed a commit
that referenced
this pull request
Oct 10, 2026
Positive control for #882: with the report on !cancelled(), a failed need must still run the report and turn it red. Not for merge; the branch is deleted after the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary by t27-beesThis change prevents the Brain Health Report job from running when the workflow run itself is cancelled (e.g., superseded by a newer push). Previously Worth a look
Read: 1 files, +4 -1, the whole diff. Head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #881. Part of #851.
What was wrong
brain-health-reportinbrain-ci.ymlran onif: always(). It reported DAMAGE and ranexit 1unless all sixneedsweresuccess, and on a pull request it then posted "🚨 CRITICAL: Brain Health Below Threshold … This PR cannot be merged".A cancelled need is not
success, so when a newer push cancelled a run, the report treated the cancel as brain damage. On #870:main'sbrain-ci.ymlhas noconcurrency:block, so today this happens only on a manual cancel. #870 addscancel-in-progressfor pull requests, which would make it happen on every push during a run.The change
One line:
if: always()→if: ${{ !cancelled() }}, with a comment.cancelled()is true only when the workflow run was cancelled, so the report still runs after a need fails, and still goes red and posts.Scope
Of the 10 jobs on
mainwith a job-levelalways(), this is the only one that requiressuccessfrom its needs.fpga-ci.ymlandfpga-regression.ymlhavesummaryjobs that exit 1 only on== 'failure', which a cancelled need does not match. No step-levelalways()step posts a comment. Scan: a text scan of.github/workflowsat 57de4a1.Checked locally
tools/check_run_syntax.py: 122 of 122 workflows, 0 steps that do not parse.tools/check_tee_pipefail.py: 78 known, 0 new.research/audit_workflow_paths.py: 0 dead paths.git merge-treeis clean against ci: give the 102 push workflows a dispatch-safe concurrency group #870, ci(brain): stop calling tri stress --record, and let the weekly stress step fail #880, ci: run nine workflows once per PR commit, on every path their push run watched #876, ci: run the nine document gates on push to main only #867 and fix(gates): green doc-refs and orphan-artefacts on main after #510 #872.Shown by CI, 2026-10-04
Four brain-ci runs. The two cancelled ones were cancelled at the same point, while the stress test was running, which is where #870's run was cancelled.
📋 Brain Health Reportmain(always())[ "cancelled" == "success" ]→ DAMAGE →exit 1. This is the defect, reproduced.cancelled(notskipped, as I first predicted).successexp/report-fail-ab= this branch + a forcedexit 1in Build Check[ "failure" == "success" ]→ DAMAGE →exit 1. A real failure is still red.The two dispatched runs could not post a comment, because the notification step runs only on
pull_request. What these runs show is the report's result, which is the step's precondition.exp/report-fail-abis a throwaway branch with one commit (88bc1eb). It is not for merge.Not measured
timeout-minutes. The workflow is not cancelled then, so the report runs, but I did not check which result the need gets.detect-buildfinishes. The report onmainthen takes its "skipped" branch and passes (inferred from run 37227380293, not reproduced). This PR does not change that branch.🤖 Generated with Claude Code