Skip to content

ci(brain): let the merge gate fail, and fail on a failed detect-build #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gHashTag wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci(brain): let the merge gate fail, and fail on a failed detect-build #884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6250a54
ci(brain): let the merge gate fail, and fail on a failed detect-build
gHashTag Oct 4, 2026
98da33e
style(brain): name the bool the detect-build verdict tests
gHashTag Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/brain-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,14 @@ jobs:
echo "" >> $GITHUB_STEP_SUMMARY

echo "## Verdict" >> $GITHUB_STEP_SUMMARY
# A failed detect-build never writes `present`, and the test below
# read the empty value as "no root build.zig" and passed (#883).
detect_failed=true
[ "${{ needs.detect-build.result }}" == "success" ] && detect_failed=false
if [ "$detect_failed" = true ]; then
echo "### ! Brain CI cannot tell whether it applies: detect-build was ${{ needs.detect-build.result }}" >> $GITHUB_STEP_SUMMARY
exit 1
fi
# When the root build.zig is absent, all brain jobs are `skipped`
# (see detect-build). That is an honest "not applicable" state for
# the current RTL/HW-focused repo, not damage — do not block on it.
Expand Down Expand Up @@ -622,7 +630,10 @@ jobs:
name: 🔒 Merge Gate
runs-on: ubuntu-latest
needs: [brain-health-report]
if: github.event_name == 'pull_request'
# Without a status function GitHub adds success(), so this job ran only
# after a passing report and its "report did not pass" test could never
# be true: a damaged PR showed the gate as grey `skipped` (#883).
if: ${{ !cancelled() && github.event_name == 'pull_request' }}
timeout-minutes: 2
steps:
- name: Check Merge Eligibility
Expand Down
Loading