Repository navigation
Conversation
- fpga/esp32_wifi_bridge: Wi-Fi AP credentials move to a gitignored secrets.h (secrets.h.example added); connection guide uses placeholders - deploy/trinity-nexus/canvas and src/trinity_node main_gui.zig: wallet password read from the environment - tools/telegram-bridge/2fa-neuro-sage.sh: 2FA password from the environment - .gitleaks.toml: shared rules (canonical copy gHashTag/t27 PR #6433) plus narrow allowlists for synthetic Kaggle data, public contract addresses, archived spec examples, QA fixtures and three verified lines - lefthook.yml: secret-gate on pre-commit and pre-push - .github/workflows/secret-scan.yml: CI twin over the PR range - .gitignore: secrets.h, .creds; README: secrets section Same fixes as gHashTag/trinity-fpga PR #900. Closes #1430 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 37883008 | Triggered | Generic Password | 0b74c39 | tools/telegram-bridge/2fa-neuro-sage.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Contributor
X Brain Health CheckScore: 100.0/100 X Brain is above merge threshold |
Contributor
🧪 Brain Stress Test ResultsTests: 261/261 passed, 0 leaked |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1430
What changed
Same fixes as gHashTag/trinity-fpga PR #900, applied to the files this repo shares with it, plus the secret gate.
fpga/esp32_wifi_bridge/esp32_wifi_bridge.ino: AP credentials move to a gitignoredsecrets.h;secrets.h.exampleadded.fpga/COMPLETE_CONNECTION_GUIDE.md: placeholders instead of the Wi-Fi password.deploy/trinity-nexus/canvas/src/main_gui.zig,src/trinity_node/main_gui.zig: wallet password read from the environment (fails witherror.MissingWalletPasswordwhen unset).tools/telegram-bridge/2fa-neuro-sage.sh: 2FA password from the environment..gitleaks.toml: shared[extend]+hardcoded-password-literalrule, byte-identical with the canonical copy (gHashTag/t27 PR #6433). Narrow allowlists: synthetic Kaggle data (1381 stripe-pattern false positives), public contract deployment JSON, archived.vibeespec examples, QA fixtures, and three lines (public token address, RFC 6455 example nonce, a registry slot name) plus the S07 prose note.lefthook.yml:secret-gateadded to the existing pre-commit and pre-push (existing commands kept). This repo usescore.hooksPath=.githooks, whose tracked hooks calllefthook run, so the gate runs withoutlefthook install..github/workflows/secret-scan.yml: new CI twin scanning the PR / push range..gitignore:secrets.h,.creds.README.md: "Secrets never enter the repository" section (no SECURITY.md here).The docs/book generators, Kaggle scripts and ralph report script that held keys in trinity-fpga were already reading from the environment here.
Branch is
fix/secret-gate, notsecurity/...: the repo's pre-push branch-name rule only accepts feat|fix|docs|refactor|test|chore.Verified
gitleaks dir . --config .gitleaks.toml-> exit 0const char* wifi_password = "hunter2hunter2";->gitleaks git --stagedexit 1 (probe removed)lefthook install-> exit 1 (refuses becausecore.hooksPathis set to.githooks; left as is). The commit went through pre-commitsecret-gateand the push through pre-pushsecret-gatevia.githooks.Credentials to rotate
They were pushed, so removing them does not unpublish them:
fpga/esp32_wifi_bridge/esp32_wifi_bridge.ino,fpga/COMPLETE_CONNECTION_GUIDE.mddeploy/trinity-nexus/canvas/src/main_gui.zig,src/trinity_node/main_gui.zigtools/telegram-bridge/2fa-neuro-sage.sh🤖 Generated with Claude Code