Skip to content

fix(website): the course shelf's border fallback says what --border says (pure gates green) - #1700

Merged
gHashTag merged 1 commit into
mainfrom
fix/course-shelf-fallback
Oct 19, 2026
Merged

gHashTag merged 1 commit into
mainfrom
fix/course-shelf-fallback

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

What

One line in apps/website/src/pages/Course.css:743. The fallback of the .course-shelf border now says what --border says: rgba(255, 255, 255, 0.08) instead of 0.12.

Why

check:queen-fallback-parity, the step "A fallback says what the token says", has failed 234/235 on main since 6e6c6df. That makes checks (pure gates) and website gate red on every website PR, among them #1696 and #1699. --border is declared on :root (index.css:7), so the token always resolves and the fallback never drew. The page looks the same before and after this change.

{
  "version": 1,
  "head_sha": "b5b999e71174a9e960d46cb0b329a180dd56268d",
  "summary": "Every website PR showed a red pure-gates check because one CSS fallback on the course shelf disagreed with the token it falls back from; the fallback now says what the token says, so the gate is green again and a red there means a real regression.",
  "changes": [
    "src/pages/Course.css line 743: the .course-shelf border falls back to rgba(255, 255, 255, 0.08), the value --border is declared with on :root in index.css line 7, instead of 0.12. The token always resolves, so the drawn border does not change."
  ],
  "tests": [
    {
      "command": "cd apps/website && node qa/queen-fallback-parity.mjs",
      "status": "passed",
      "result": "FAIL (234/235) on main before the change, PASS (235/235) after it",
      "evidence": "local run on origin/main 7c945f07 and on b5b999e71174a9e960d46cb0b329a180dd56268d"
    }
  ],
  "limitations": [
    "Only the fallback changes; the drawn border is the token's 0.08 before and after, because --border is declared on :root and always resolves on the course page."
  ],
  "tags": [
    "Engineering",
    "Website"
  ],
  "blog": {
    "title": "One CSS fallback turned every website PR red, and now says what its token says",
    "summary": "The course shelf's border fallback disagreed with the --border token, so the pure-gates check failed on every website pull request; the fallback now matches the token.",
    "outline": [
      "The pure-gates check compares every var() fallback with the token it names, and one on the course shelf said 0.12 where the token says 0.08.",
      "The token always resolves on the course page, so the border never changed, but the gate failed on every website pull request since 6e6c6df2 and hid real regressions.",
      "The fallback now says 0.08 like the token; the check goes from 234 of 235 to 235 of 235, and a red pure-gates check means something again."
    ],
    "reproduce": [
      "cd apps/website && node qa/queen-fallback-parity.mjs"
    ]
  }
}

Generated by Claude Code

…ays (pure gates green)

check:queen-fallback-parity failed 234/235 on main since 6e6c6df: .course-shelf wrote
var(--border, rgba(255, 255, 255, 0.12)) while --border is declared rgba(255, 255, 255, 0.08)
on :root (index.css:7). The token always resolves there, so the fallback was dead and the page
draws the same; now the fallback says what draws, and checks (pure gates) / website gate go
green for every website PR (red on #1696, #1699 and others).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
@tri-claw

tri-claw Bot commented Oct 19, 2026

Copy link
Copy Markdown

Summary by t27-bees

This change aligns a CSS fallback value with its token (--border) so the queen-fallback-parity gate passes. The --border token is declared on :root and always resolves, so the fallback was never used and the rendered border stays the same.

Worth a look

  • Nothing stood out.

Read: 1 files, +1 -1, the whole diff. Head b5b999e. Model: openai-compatible/nvidia/nemotron-3-ultra-550b-a55b. Commands: @t27-bees review | summary | help | pause | resume. Free for every repository.

@github-actions github-actions Bot added the status:in-progress 🔵 Agent working label Oct 19, 2026
@gHashTag
gHashTag merged commit 8e535bc into main Oct 19, 2026
14 checks passed
@github-actions github-actions Bot added status:completed Done and removed status:in-progress 🔵 Agent working labels Oct 19, 2026
github-actions Bot added a commit that referenced this pull request Oct 19, 2026
fix(website): the course shelf's border fallback says what --border says (pure gates green) (#1700)

check:queen-fallback-parity failed 234/235 on main since 6e6c6df: .course-shelf wrote
var(--border, rgba(255, 255, 255, 0.12)) while --border is declared rgba(255, 255, 255, 0.08)
on :root (index.css:7). The token always resolves there, so the fallback was dead and the page
draws the same; now the fallback says what draws, and checks (pure gates) / website gate go
green for every website PR (red on #1696, #1699 and others).

Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants