Repository navigation
fix(website): the course shelf's border fallback says what --border says (pure gates green) - #1700
Merged
Merged
Conversation
…ays (pure gates green) check:queen-fallback-parity failed 234/235 on main since 6e6c6df: .course-shelf wrote var(--border, rgba(255, 255, 255, 0.12)) while --border is declared rgba(255, 255, 255, 0.08) on :root (index.css:7). The token always resolves there, so the fallback was dead and the page draws the same; now the fallback says what draws, and checks (pure gates) / website gate go green for every website PR (red on #1696, #1699 and others). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k
Summary by t27-beesThis change aligns a CSS fallback value with its token ( Worth a look
Read: 1 files, +1 -1, the whole diff. Head |
github-actions Bot
added a commit
that referenced
this pull request
Oct 19, 2026
fix(website): the course shelf's border fallback says what --border says (pure gates green) (#1700) check:queen-fallback-parity failed 234/235 on main since 6e6c6df: .course-shelf wrote var(--border, rgba(255, 255, 255, 0.12)) while --border is declared rgba(255, 255, 255, 0.08) on :root (index.css:7). The token always resolves there, so the fallback was dead and the page draws the same; now the fallback says what draws, and checks (pure gates) / website gate go green for every website PR (red on #1696, #1699 and others). Claude-Session: https://claude.ai/code/session_01ScHVrGSr6zZUdwkdC8DR9k Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One line in
apps/website/src/pages/Course.css:743. The fallback of the.course-shelfborder now says what--bordersays:rgba(255, 255, 255, 0.08)instead of0.12.Why
check:queen-fallback-parity, the step "A fallback says what the token says", has failed 234/235 on main since 6e6c6df. That makeschecks (pure gates)andwebsite gatered on every website PR, among them #1696 and #1699.--borderis declared on:root(index.css:7), so the token always resolves and the fallback never drew. The page looks the same before and after this change.{ "version": 1, "head_sha": "b5b999e71174a9e960d46cb0b329a180dd56268d", "summary": "Every website PR showed a red pure-gates check because one CSS fallback on the course shelf disagreed with the token it falls back from; the fallback now says what the token says, so the gate is green again and a red there means a real regression.", "changes": [ "src/pages/Course.css line 743: the .course-shelf border falls back to rgba(255, 255, 255, 0.08), the value --border is declared with on :root in index.css line 7, instead of 0.12. The token always resolves, so the drawn border does not change." ], "tests": [ { "command": "cd apps/website && node qa/queen-fallback-parity.mjs", "status": "passed", "result": "FAIL (234/235) on main before the change, PASS (235/235) after it", "evidence": "local run on origin/main 7c945f07 and on b5b999e71174a9e960d46cb0b329a180dd56268d" } ], "limitations": [ "Only the fallback changes; the drawn border is the token's 0.08 before and after, because --border is declared on :root and always resolves on the course page." ], "tags": [ "Engineering", "Website" ], "blog": { "title": "One CSS fallback turned every website PR red, and now says what its token says", "summary": "The course shelf's border fallback disagreed with the --border token, so the pure-gates check failed on every website pull request; the fallback now matches the token.", "outline": [ "The pure-gates check compares every var() fallback with the token it names, and one on the course shelf said 0.12 where the token says 0.08.", "The token always resolves on the course page, so the border never changed, but the gate failed on every website pull request since 6e6c6df2 and hid real regressions.", "The fallback now says 0.08 like the token; the check goes from 234 of 235 to 235 of 235, and a red pure-gates check means something again." ], "reproduce": [ "cd apps/website && node qa/queen-fallback-parity.mjs" ] } }Generated by Claude Code