You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
queen: a review with no lane free waits for one in a bounded queue - review_lanes.t27, behind TRIOS_QUEEN_REVIEW_LANES=semaphore #1737
With scarce lanes the adaptive reviewer pool (#1715, #1716, reviewer_sizing.t27) loses to the fixed 4 on the benchmark's second table. On the same seeded input with 3 free lanes:
overload: 360/660 against 429/660;
burst: 352/365 against 365/365.
The cause is in how a review uses its lane. It holds the lane only during its model call, and it asks for one about 30% of the way in. If no lane is free at that point, it answers wait. A pool capped at the lane count therefore leaves lanes idle during the first 30% of every review. The fixed 4 overlaps that phase, but at the price of hundreds of lane-less wait visits. Each of those visits throws away a witness and a criteria measurement, and due_again pushes the row back.
Runtime: a review-lanes actor. It is the first child of the reviewer domain and owns the queue. Reviews reach it through a LaneGate, which waits by call with the card's timeout. The gate is wired into the reviewer's model-call step in queen-tick.ts. All of this sits behind TRIOS_QUEEN_REVIEW_LANES=semaphore, off by default. It works with and without TRIOS_QUEEN_REVIEWER_ADAPTIVE and TRIOS_QUEEN_TURN_STOP: a stopped turn leaves the queue or releases its lane.
Benchmark: the second table of tests/api/queen-actors-bench.test.ts runs the same draws for four variants: fixed 4, adaptive, fixed 4 + queue, and adaptive + queue.
Acceptance
Adaptive + queue at least ties the fixed 4 where adaptive lost on lanes, and does not lose where adaptive won.
Shipped: #1739 merged into actors-next-2, which went into queen as 3654fdd via #1754 (2026-10-10 16:03Z). Every new behaviour stays behind its flag, off by default. Closes fires only on the default branch main, so this is closed by hand. Ledger: #1729.
Activity
Merge pull request #1739 from gHashTag/queen-review-lane-semaphore
gHashTag commentedon Oct 10, 2026
Shipped: #1739 merged into
actors-next-2, which went intoqueenas 3654fdd via #1754 (2026-10-10 16:03Z). Every new behaviour stays behind its flag, off by default.Closesfires only on the default branchmain, so this is closed by hand. Ledger: #1729.