You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Queen: a redispatch after a spent ceiling should get a full set of send-backs (option (a) of #1769, depends on t27#8768) #1806
Give a redispatched issue the full set of attempts that the original design intended. This is option (a) from #1769. Option (b) corrected only the comments and leaves the behaviour unchanged. That is done in a separate PR.
What happens today
After a spent send-back ceiling is handed back, the redispatch carries ceiling_releases = 1. Its first send-back reaches the review valve as KIND_SEND_BACK_CEILING with releases = 1. next_step (specs/queen/review_valve.t27) answers STEP_CLOSE once releases >= MAX_RELEASES. So the claim becomes cancelled and the row is closed as obsolete. Details and the reproduction are in #1769.
Proposed rule
A send-back under the ceiling never asks the valve. It holds as rejected until its own one-hour floor and is then released. Only a send-back at the ceiling goes to the valve.
specs/queen/claim.t27 in gHashTag/t27 changes the sendBack branch of claim_of: under the ceiling, the result is CL_REJECTED inside the send-back floor and CL_FAILED after it, for any releases.
The spec tests show a redispatched issue getting maximumSendBacks counted send-backs before the valve closes it. The seal is regenerated.
In trios: the card is re-vendored, claim.wasm is rebuilt, specs/PIN is updated, and tests/api/queen-claim-card.test.ts is updated so the reference rule matches the new branch.
Activity