Repository navigation
docs(queen): a redispatch after a spent ceiling gets one attempt, not one more set - #1807
Conversation
… one more set (gHashTag#1769) The comments above MAX_CEILING_RELEASES (queen-tick.ts) and the redispatch upsert (queen-dispatch.ts) described one more full set of attempts. The code gives one: the redispatch carries ceiling_releases = 1, and its first send-back is closed as obsolete by the review valve (next_step answers STEP_CLOSE once releases >= MAX_RELEASES). Comments only; behaviour is unchanged. Option (a), the behaviour change, is tracked separately. Closes gHashTag#1769
Summary by t27-beesThis PR updates comments in two files to clarify that a redispatch after a spent ceiling grants exactly one more attempt (not "one more set" of attempts). The comments now explain the mechanism: Worth a lookNothing stood out. Read: 2 files, +13 -5, the whole diff. Head |
|
CI on 21642fe: all 15
This PR changes comments only, so it adds no findings. Merging into Dmitrii Fedorov (@dmitrii-f-t27) |
Closes #1769
What
Option (b) of #1769: the behaviour stays, and two comments now state what the code does.
queen-tick.ts, aboveMAX_CEILING_RELEASES: it said the bee gets "one more set" of attempts after a spent ceiling. It now says one more attempt, and explains why.queen-dispatch.ts, the redispatch upsert: it said the new attempt "is judged on its own work". It now says thatsend_backsrestarts at 0, butceiling_releasesis already atMAX_RELEASES, so the first send-back of the hand-back is closed as obsolete by the review valve.Mechanism (unchanged, on
queen@ fc0b59d): the redispatch setsceiling_releases = 1. The next send-back goes tonextStep(KIND_SEND_BACK_CEILING, idleMinutes, releases).next_stepinspecs/queen/review_valve.t27returnsSTEP_CLOSEoncereleases >= MAX_RELEASES(MAX_RELEASES = 1). The claim becomescancelled.Scope
queen..t27spec change: no behaviour changes. The behaviour is already pinned byspecs/queen/claim.t27in spec(queen): claim.t27 - the round's stateOfDispatch as a card, the review valve imported (Closes #8765) t27#8768 (testa_send_back_under_its_ceiling_goes_back_after_the_hour).git merge-treeagainst feat(queen): the round's claim is decided by the claim card, proven equal to the hand-written rule first (Closes #1767) #1768 (head 9a9e124): no conflict.Checks
bun build --no-bundle). The SQL comment stays inside the template literal (no backticks added).Dmitrii Fedorov (@dmitrii-f-t27)