Skip to content

docs(queen): a redispatch after a spent ceiling gets one attempt, not one more set - #1807

Merged
dmitrii-f-t27 merged 1 commit into
gHashTag:queenfrom
dmitrii-f-t27:docs/queen-1769-one-more-attempt
Oct 11, 2026
Merged

dmitrii-f-t27 merged 1 commit into
gHashTag:queenfrom
dmitrii-f-t27:docs/queen-1769-one-more-attempt

Conversation

@dmitrii-f-t27

Copy link
Copy Markdown
Collaborator

Closes #1769

What

Option (b) of #1769: the behaviour stays, and two comments now state what the code does.

  • queen-tick.ts, above MAX_CEILING_RELEASES: it said the bee gets "one more set" of attempts after a spent ceiling. It now says one more attempt, and explains why.
  • queen-dispatch.ts, the redispatch upsert: it said the new attempt "is judged on its own work". It now says that send_backs restarts at 0, but ceiling_releases is already at MAX_RELEASES, so the first send-back of the hand-back is closed as obsolete by the review valve.

Mechanism (unchanged, on queen @ fc0b59d): the redispatch sets ceiling_releases = 1. The next send-back goes to nextStep(KIND_SEND_BACK_CEILING, idleMinutes, releases). next_step in specs/queen/review_valve.t27 returns STEP_CLOSE once releases >= MAX_RELEASES (MAX_RELEASES = 1). The claim becomes cancelled.

Scope

Checks

  • Both edited files parse with Bun 1.3.6 (bun build --no-bundle). The SQL comment stays inside the template literal (no backticks added).
  • CI on this PR: see the checks below.

Dmitrii Fedorov (@dmitrii-f-t27)

… one more set (gHashTag#1769)

The comments above MAX_CEILING_RELEASES (queen-tick.ts) and the redispatch
upsert (queen-dispatch.ts) described one more full set of attempts. The
code gives one: the redispatch carries ceiling_releases = 1, and its first
send-back is closed as obsolete by the review valve (next_step answers
STEP_CLOSE once releases >= MAX_RELEASES). Comments only; behaviour is
unchanged. Option (a), the behaviour change, is tracked separately.

Closes gHashTag#1769
@tri-claw

tri-claw Bot commented Oct 11, 2026

Copy link
Copy Markdown

Summary by t27-bees

This PR updates comments in two files to clarify that a redispatch after a spent ceiling grants exactly one more attempt (not "one more set" of attempts). The comments now explain the mechanism: send_backs resets to 0 but ceiling_releases is already at MAX_RELEASES (1), so the first send-back hits the review valve with releases >= MAX_RELEASES and gets STEP_CLOSE, cancelling the claim.

Worth a look

Nothing stood out.


Read: 2 files, +13 -5, the whole diff. Head 21642fe. Model: openai-compatible/nvidia/nemotron-3-ultra-550b-a55b. Commands: @t27-bees review | summary | help | pause | resume. Free for every repository.

@dmitrii-f-t27

Copy link
Copy Markdown
Collaborator Author

CI on 21642fe: all 15 Tests jobs and GitGuardian pass.

Code Quality is red. The findings are the same as on queen itself (run 38097722846 on 3c1b8c7, a recent push to queen):

  • Biome: 20 errors and 122 warnings on both. The set of 126 file+rule findings is identical (diff is empty). The findings in queen-tick.ts and queen-dispatch.ts are existing noExcessiveCognitiveComplexity hits. Their line numbers moved by the added comment lines.
  • Typecheck: the same 19 error TS* lines (file + code) on both, diff is empty.

This PR changes comments only, so it adds no findings. Merging into queen the same way as the recent merges into queen.

Dmitrii Fedorov (@dmitrii-f-t27)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant