Repository navigation
test(trios-chat): behaviour baseline, golden vectors, laws hash and pin tests - #1827
Open
dmitrii-f-t27 wants to merge 5 commits into
Open
dmitrii-f-t27 wants to merge 5 commits into
dmitrii-f-t27 wants to merge 5 commits into
Conversation
The root Cargo.toml lists the 12 trios-chat ring crates but not the shim crates/trios-chat, so cargo refused to build it and e2e_chat_25, falsifier_runner and tests/r_chat_guard.rs never ran in CI. Cargo.lock gains only the trios-chat package entry. Refs #1814 L16 rationale: clippy -D warnings already fails at base 8b229e9 and ci.yml skips it; this PR changes no Rust source.
…golden Test names per package (cargo test -- --list) and pass counts for 12 of the 13 chat packages, e2e_chat_25 PASS list (25/25), falsifier_runner stdout, exit code (1) and skipped corpus lines (400), and golden_vectors output (3722 lines, identical on two runs). trios-chat-br-io-chat-07 is not measured yet and follows in a separate commit. Refs #1825 L16 rationale: clippy -D warnings already fails at base 8b229e9 and ci.yml skips it; this change adds only data files.
Summary by t27-beesThis PR establishes a frozen behavior baseline (golden tests, vectors, and pins) for Worth a look
Read: 27 files, +10675 -0, a summary only: the diff is larger than 4000 changed lines, so it was not read line by line. Head |
9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1825
Part of #1812 (Trinity Secure Chat written once in .t27).
Stacked on #1820 and contains its commit (adbe1a1, workspace member). Merge 1820 first.
What it adds
crates/trios-chat/golden/: the frozen behaviour baseline that every later swap of generated code must reproduce.test-names/<package>.txt: sortedcargo test -p <package> -- --listnames;counts.txt: listed and passed counts.e2e_pass.txt(25/25 PASS),falsifier.stdout,falsifier.exit(1),falsifier.skips(400).vectors.txt: output of the newgolden_vectorsbin, 3722 lines, identical on two runs, no OS randomness.src/bin/golden_vectors.rs: deterministic vectors (laws hash, padding classes, dest hash, sealed envelope with fixed secrets and nonce, chain steps, DH steps, receive-accept paths, prekey bundle canonical bytes, capability token and tool manifest signing bytes, injection verdicts for every corpus line plus benign strings). ASCII-only source.tests/laws_hash.rs: pins hex(laws_hash) = d8c962d0cfe111bf72f9d59f2296baf015ff5c9f0390cf807b7cc08c706f3a98.T27_PIN(empty table: file, spec path, t27 SHA, t27c built_by, sha256, seal file) andtests/t27_pin.rs(sha256 of each vendored generated file equals its PIN row).T27_EXCEPTIONS.md: 8 files proposed to stay hand-written Rust (glue, SeaORM/tokio I/O, the e2e gate). Marked "proposed, pending owner decision D11".sha2 = "0.10"in the shim's[dev-dependencies](the rings already use 0.10);Cargo.lockgains one dependency line.Measured on b9b05c4 + this head (local, cargo 1.94.0, rustc 1.94.0, repository Cargo.lock, DATABASE_URL unset)
find crates/trios-chat -name '*.sh' | wc -l: 0.No ring source changes. The falsifier is not added as a gate (it exits 1 today; any fix is a separate PR).
L16 rationale: clippy -D warnings already fails at base 8b229e9 and ci.yml skips it; this PR adds tests, one bin and data files.
CODEOWNERS: this PR changes /Cargo.lock; it is merged only after @gHashTag's approval (requested by email).
Dmitrii Fedorov (@dmitrii-f-t27)