test(agent): pin the AI settings page - AISettingsPage (Closes #1504)

[dmitrii-f-t27]

Closes #1504

What

The first suite for apps/agent/entrypoints/app/ai-settings/AISettingsPage.tsx (AISettingsPage, the only export), under bun test in the agent group — unblocked by the shared session-seam repair of #1980.

• describe block: AISettingsPageTsxContract (appears nowhere else in the tree).
• This was the issue that exposed bun's frozen-facade rule: the page statically imports useSessionInfo from the auth session seam, and the earliest-linking registrar's stand-in lacked that name, so the subject could not even link in the group (diagnosed in test(agent): pin the AI settings page - AISettingsPage (Closes #1504) #1960 with 2-file repros; repaired in test(agent): pin the chat history - ChatHistory (Closes #1647) #1980 by completing the earliest registrar's stand-in). The suite itself is recovered from test(agent): pin the AI settings page - AISettingsPage (Closes #1504) #1960's head, unchanged: the page renders framed with its providers heading.
• FR-004 shown both ways, quoted fresh on this branch: broken subject (an always-null early return spliced before the page render) → 0 pass / 1 fail; restored → 1 pass / 0 fail / 2 expect(). git diff --name-only lists only the new test file.

Local gates

• Suite: 1 pass / 0 fail (2 expect()); grep -c 'it(' = 1; 1 + 0 blocked = 1.
• Group (apps/agent): 390 pass / 3 fail / 393 tests — the 3 = the pre-existing port-helper noise, unchanged from baseline. The full group with this suite is the direct proof the repair holds: the subject links and renders under the completed facade.
• Biome: 0. Typecheck: 0 errors / 0 mentions.

No database, no container, no network.

[tri-claw]

Summary by t27-bees

This PR adds a contract test for AISettingsPage.tsx that renders the page with all its external seams stubbed, verifying the initial mount shows the framed page with its "LLM Providers" heading. The test was previously blocked by bun's frozen-facade rule on the auth session seam (fixed in #1980).

Worth a look

• AISettingsPage.test.ts:19-20 — process.env.VITE_BROWSEROS_SERVER_PORT ??= '43210' mutates the global process.env before any imports. If another test in the group runs first and reads the env module, the one-time snapshot may capture a different value or the mutation may arrive too late, causing flaky port resolution.
• AISettingsPage.test.ts:22-35 — The values Map is declared at module scope and shared across all tests in the file. With only one test today this is harmless, but any future it block will inherit mutated storage state unless values.clear() is called in a beforeEach.
• AISettingsPage.test.ts:58-63 — The session seam workaround imports the real module via ?ai-settings-real query parameter to bypass bun's facade freeze. This relies on non-standard import specifier behavior; if the bundler or bun changes how query parameters are handled, the spread will fail or pull the wrong module graph.
• AISettingsPage.test.ts:84-89 — Same query-parameter trick for react-router. If react-router doesn't support query-qualified imports, realRouter becomes an empty object and the spread drops all other exports, breaking any component that uses useParams, useLocation, etc.
• AISettingsPage.test.ts:94-97 — The subject import uses ?ai-settings-suite-real to force a fresh module graph. If the component or its transitive dependencies have side effects on import (e.g., registering global listeners), those side effects will run again per test file, potentially leaking across the group.

---

_{Read: 1 files, +141 -0, the whole diff. Head 3b34d4d. Model: openai-compatible/nvidia/nemotron-3-ultra-550b-a55b. Commands: @t27-bees review | summary | help | pause | resume. Free for every repository.}

[github-actions]

✅ Tests passed — 3800/3870

Suite	Passed	Failed	Skipped
✅ agent	398/398	0	0
✅ build	9/9	0	0
✅ cdp-protocol	5/5	0	0
✅ eval	93/93	0	0
✅ server-agent	280/280	0	0
✅ server-api	2189/2258	0	69
✅ server-browser	6/6	0	0
✅ server-integration	10/11	0	1
✅ server-lib	279/279	0	0
✅ server-pglive	166/166	0	0
✅ server-root	68/68	0	0
✅ server-sim	8/8	0	0
✅ server-skills	31/31	0	0
✅ server-tools	244/244	0	0
✅ shared	14/14	0	0

View workflow run