Repository navigation
test(agent): pin the agent command home contract - AgentCommandHome - #2028
Merged
Merged
Conversation
Closes #1594 The alert stand-in's root honours the open flag (the first push passed content through unconditionally and broke the sibling Skills and ScheduledTasks closed-alert pins in the CI readdir order).
Summary by t27-beesWorth a look
Read: 2 files, +287 -0, the whole diff. Head |
β Tests passed β 3815/3885
|
Collaborator
Author
|
Gate check before merge: Tests: 19/19 green on this exact SHA - incl. runner / Typecheck - GREEN, 0 errors, 0 mentions of this PR's file. runner / Biome - red from base, 0 mentions of this PR's file, 0 new findings. Dmitrii Fedorov (@dmitrii-f-t27) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1585
First suite for
entrypoints/app/agent-command/AgentCommandHome.tsx(218 lines, unmodified). The seams are the ones the AgentCommandConversation suite stubs (this group's pattern): the wxt storage item shim, the layout data hook behind a fixture, the agents/adapters hooks, the metrics seam, the active-hint hook behind a flag, and the ConversationInput stubbed with a marker carrying the measured placeholder (its own suite owns its internals). Four tests: the empty answer (No agents yet with its note and the Create agent affordance, no home headline); the populated answer - the home headline with its italic work-on accent, the tab-leaving note, the conversation slot, and the MEASURED static-render reality: the selection effect never runs, so the input answers the not-running placeholder even with agents present and the Recent-threads section stays away while the harness list is empty; the recent-threads visibility gate (the harness list drives it); and the hint dispatch (signin answers the SignInHint's measured Sync-your-data card, import the ImportDataHint's measured Import-your-data headline, none answers neither). Not pinned: the send/select wiring.Verified: suite alone 4/4; broken copy (the empty title shortened, the accent word swapped, the headline reworded - valid syntax) 2 catcher tests fail, restored byte-identical; biome clean after one auto-format; tsgo with 0 mentions of this file.
Spec: the issue is the executable contract for a test-only change; the suite is the pin.
Dmitrii Fedorov (@dmitrii-f-t27)