Repository navigation
Keep a workout's heart rate running: restart on reconnect and after silence - #89
Merged
Merged
Conversation
…ilence The 17 Nov gym session read 76 bpm over 12 of 57 minutes. The ring's own minute log in the export shows live readings 06:56-07:00 and then only its routine checks: the ring stopped measuring four minutes in and nothing asked it again. - A real reconnect mid-workout re-sends the start, as the vendor's run screen does (RunRecordActivity, BLE state 2). - A workout started while the ring is away starts its stream on connect; the start used to be dropped. - A connected ring silent for 60 s mid-workout gets the start again. - RingSyncWorker skips while a workout records: it opened a second client, re-ran the startup and broadcast DISCONNECTED. - Starts, restarts, stops and jring's chosen command go to diagnostics. Claude-Session: https://claude.ai/code/session_01P1t1aUqSUPd3whKXmgVm7w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
The owner's 17 Nov gym session (2.16.17, jring) read 76 bpm with readings covering only 12 of 57 minutes. A Huawei watch on the same session read 107 / 146.
The diagnostics export only held the last four minutes before it was taken, but it included the ring's own minute log (unmasked "full" export):
So the ring stopped measuring about four minutes in, and nothing asked it to start again. What stopped it is outside the export. It was either a start sent before the
0x20reply (which falls back to the 180 s check), or a later command ending the live mode.Changes
RingSyncCoordinator): a real reconnect during a workout re-sends the workout start. The vendor's run screen does exactly this (RunRecordActivity, BLE state 2 →startHeartrateMode(true)).RingSyncWorker): skips while a workout records. With the screen off it used to open a second client, re-run the whole startup (settings writes included) and broadcast DISCONNECTED.docs/jring-56ff-plan.md.Checks
mainhas in this container.Generated by Claude Code