Repository navigation
Accuracy check grades both rings against the watch - #91
Merged
Merged
Conversation
The owner wears a JRing and a Colmi R06 with a Huawei watch and asked the accuracy check to grade both. A running check now scores the comparison ring against the same reference in the same pass: heart rate at rest and active, steps, SpO2, time asleep, fell asleep and woke up, with its own off-time gaps and the main ring's rules. Its rows are stored as CMP:<metric>, so the main ring's report cards, corrections and export pause never see them. The report opens with "Both rings against [reference]": each ring's typical gap, the closer one in bold, and a tally of which ring was closer on how many measures. Docs: docs/ring-comparison.md, AGENTS.md. Audit: audits/2026-11-18-accuracy-both-rings.md. Claude-Session: https://claude.ai/code/session_01P1t1aUqSUPd3whKXmgVm7w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner wears a JRing (main) and a Colmi R06 (comparison) alongside a Huawei watch, and asked for the accuracy check to grade both rings against the watch.
Scoring
AccuracyScorer.scoreComparisonRingruns in the same pass as the main ring, against the same reference data:The comparison ring's off time comes from its own data, and it is the comparison ring that recorded most during the check (
ComparisonDao.mostRecordedAddress).Isolation
CMP:<metric>inaccuracy_check_days(ComparisonRingScoring.tag). The main ring's report cards, corrections and export pause match exact metric names, so they never see them.Report
A new first card, Both rings against [reference]:
"About the same" means the two gaps are within a fifth of the measure's band or 10 % of each other. The card is absent when no second ring was worn.
Checks
ComparisonRingScoringTest(tagging and isolation, night onset/wake/asleep, daily steps, the closer rule). Full suite: 2077 tests, the same 3 environment-only failures asmainhas in this container.docs/ring-comparison.md, the AGENTS.md rule updated (the accuracy check now also readscomparison_readings), andaudits/2026-11-18-accuracy-both-rings.md.Generated by Claude Code