Repository navigation
Diagnostics capture the comparison ring's packets - #93
Merged
Merged
Conversation
An export showed the second ring's requests and none of its replies, so an empty ring and dropped replies looked the same. DiagnosticsSubscriber now also reads ComparisonBus for packets and a few status lines; the packets are masked like the main ring's and marked "ring":"comparison". Claude-Session: https://claude.ai/code/session_01P1t1aUqSUPd3whKXmgVm7w
After the listener closes, its ephemeral port can be taken at once by another test's listener in the same run, so connecting to it to prove nothing listens there failed by chance on CI (PR #93). Claude-Session: https://claude.ai/code/session_01P1t1aUqSUPd3whKXmgVm7w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the owner's 2026-11-18 export, the comparison Colmi R06 showed 47 outgoing requests and no replies at all.
DiagnosticsSubscriberonly readPulseEventBus, and the second ring publishes toComparisonBus.From what was logged, the ring answered every history request within about 30 ms, which the sync only does on an empty day:
Without the reply bytes, an empty ring and dropped replies can't be told apart.
Change
DiagnosticsSubscriberalso collectsComparisonBus, for raw packets plus[comparison ring]sync, battery and connection lines. Its readings still go only tocomparison_readings."ring":"comparison"to each packet's transport facts, and the export keeps that key.Checks
DiagnosticsTransportMetadataTestgains a case for the new key.Generated by Claude Code