Conversation
tturocy
commented
Aug 1, 2026
Member
- In the polynomial system solver, checks whether perturbations attempting to move off of a singular point are successful, rather than failing silently.
- Make the iterator over sequences iterate sequences in a deterministic order.
1. In the polynomial system solver, checks whether perturbations attempting to move off of a singular point are successful, rather than failing silently. 2. Make the iterator over sequences iterate sequences in a deterministic order.
Member
Author
|
@rahulsavani We can put this on our agenda for the next meeting, specifically w/r/t whether we want to do anything else with the tests for this method. |
rahulsavani
reviewed
Aug 13, 2026
rahulsavani
left a comment
Member
There was a problem hiding this comment.
This looks good, but I think we should expand the tests a bit. I will do that, but welcome some input:
- I will make the 4x4 coordination game not stop after only 1, but at least a few more
- I will add Bernhard's 75 eq 6x6 game, as an efg and again set a >1 but not too large stop after (by the way, finding all seems super slow); I will also take this opportunity to put that game in the catalog in a separate PR
- I will add some "true" EFGs with multiple equilibria, which will perhaps be the most important addition, maybe one with 2 players and one with 3 players
@tturocy
For the last bullet, I can come up with some examples myself, but wonder if you know any such games from papers or textbooks that would be suitable and that I could put into the catalog at the same time (I will take a pass on the existing catalog too in case I forgot about any suitable ones)?
…one for enum poly behav
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.