Skip to content

Addresses two sources of inconsistency in the output of enumpoly: - #1016

Merged
tturocy merged 7 commits into
masterfrom
issue_591
Aug 18, 2026
Merged

Addresses two sources of inconsistency in the output of enumpoly:#1016
tturocy merged 7 commits into
masterfrom
issue_591

Conversation

@tturocy

@tturocy tturocy commented Aug 1, 2026

Copy link
Copy Markdown
Member
  1. In the polynomial system solver, checks whether perturbations attempting to move off of a singular point are successful, rather than failing silently.
  2. Make the iterator over sequences iterate sequences in a deterministic order.

1.  In the polynomial system solver, checks whether perturbations attempting to move off of a singular point are successful, rather than failing silently.
2.  Make the iterator over sequences iterate sequences in a deterministic order.
@tturocy
tturocy requested a review from rahulsavani August 1, 2026 22:42
@tturocy tturocy linked an issue Aug 1, 2026 that may be closed by this pull request
@tturocy

tturocy commented Aug 1, 2026

Copy link
Copy Markdown
Member Author

@rahulsavani We can put this on our agenda for the next meeting, specifically w/r/t whether we want to do anything else with the tests for this method.

@tturocy tturocy added this to the gambit-17.0.0.alpha.2 milestone Aug 4, 2026

@rahulsavani rahulsavani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think we should expand the tests a bit. I will do that, but welcome some input:

  • I will make the 4x4 coordination game not stop after only 1, but at least a few more
  • I will add Bernhard's 75 eq 6x6 game, as an efg and again set a >1 but not too large stop after (by the way, finding all seems super slow); I will also take this opportunity to put that game in the catalog in a separate PR
  • I will add some "true" EFGs with multiple equilibria, which will perhaps be the most important addition, maybe one with 2 players and one with 3 players

@tturocy
For the last bullet, I can come up with some examples myself, but wonder if you know any such games from papers or textbooks that would be suitable and that I could put into the catalog at the same time (I will take a pass on the existing catalog too in case I forgot about any suitable ones)?

@tturocy
tturocy merged commit 3670411 into master Aug 18, 2026
26 checks passed
@tturocy
tturocy deleted the issue_591 branch August 18, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System-dependent behaviour of enumpoly on 2x2x2.nfg

2 participants