Repository navigation
build: build against the SDK fork instead of a pinned base plus patch - #2
Merged
Merged
Conversation
The upstream audio rewrite gave LightJobResult.Success two required fields and the summary no longer travelled via output data alone. The call site carries both fields explicitly.
The SDK fork now carries the package-install, Play sign-in, uninstall, pinned dependency, and exact-version allowlist work that used to be applied here as a patch plus a checked-in extension. All of it is now the SDK's own code, so the build needs no local patch step and no extension installer, and the release provenance fetches the full SDK tree rather than a base-plus-delta. As a side effect this moves Borealis off 52fbc5a and onto the fork's main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gavdevs/light-sdkmain (b1a2d85), which now carries the package-install, Play sign-in, uninstall, pinned-dependency, and exact-version allowlist work in-tree.sdk-extension/stay in the repo as a documented fallback.BorealisSyncJobfor theLightJobResult.Successsignature change from the upstream audio rewrite.Verification
assembleDebugsucceeds.:sdk:client:testDebugUnitTest --tests 'com.thelightphone.sdk.auth.*', plugin validation tests) pass against the pinned SDK.gplayapi 3.6.4,tink 1.20.0,protobuf 4.34.1) plus the SDK project modules.Notes
release-package.py) has been updated for the new provenance shape but not run end-to-end; it only runs on version tags.